Benchmarks, a few minor optimizations, 5% perf gain #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all `T: Clone` requirements, and instead the Packer will store readonly references. References can be freely copied as needed, so no issues there. I think this is a better approach because the primary usecase of this lib is to later substitute rectangles with some data, like pixels, and cloning that is expensive.` This PR also: * bumps the edition to 2021 * adds a few Debug traits * made `leaf_contains_rect` and `split_tree` not work on `self` due to borrowing rules - easier to separate them. Perhaps `Nodes` could even be made into its own separate struct, as it does not need to reference anything outside of it.
This removes all `T: Clone` requirements, and instead the Packer will store readonly references. References can be freely copied as needed, so no issues there. I think this is a better approach because the primary usecase of this lib is to later substitute rectangles with some data, like pixels, and cloning that is expensive.` This PR also: * bumps the edition to 2021 * use `Option<T>` instead of `Result<T, ()>` * A bit of a doc fix * A minor optimization for iteration * adds a few Debug traits * made `leaf_contains_rect` and `split_tree` not work on `self` due to borrowing rules - easier to separate them. Perhaps `Nodes` could even be made into its own separate struct, as it does not need to reference anything outside of it.
nyurik
changed the title
|
@ChevyRay hi, a friendly ping - let me know if anything else is needed here and in other PRs. Thanks!! |
|
hi, a friendly ping when you have a sec? Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leaf_contains_rectandsplit_treenot useselfdue to borrowing rules - easier to separate them. PerhapsNodescould even be made into its own separate struct, as it does not need to reference anything outside of it.