Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also upload sha256 for PRs #18043

Merged
merged 2 commits into from
May 20, 2024
Merged

also upload sha256 for PRs #18043

merged 2 commits into from
May 20, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented May 20, 2024

Purpose:

The new pr hash file upload falling similarly. https://github.com/Chia-Network/chia-blockchain/actions/runs/9162221971/job/25190317610

And passing when run with sha256sum. https://github.com/Chia-Network/chia-blockchain/actions/runs/9163952328/job/25195647826?pr=18043

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog CI CI changes labels May 20, 2024
Copy link

Pull Request Test Coverage Report for Build 9163952357

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 53 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.03%) to 90.831%

Files with Coverage Reduction New Missed Lines %
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/data_layer/data_layer.py 1 85.68%
chia/daemon/client.py 1 73.94%
chia/introducer/introducer.py 1 78.26%
chia/data_layer/data_store.py 2 95.85%
chia/timelord/timelord.py 2 73.67%
chia/full_node/full_node_api.py 2 81.0%
chia/wallet/wallet_node.py 3 88.79%
chia/server/node_discovery.py 7 79.43%
chia/full_node/full_node.py 11 84.87%
Totals Coverage Status
Change from base Build 9141084405: -0.03%
Covered Lines: 99196
Relevant Lines: 109150

💛 - Coveralls

@altendky altendky marked this pull request as ready for review May 20, 2024 20:18
@altendky altendky requested a review from a team as a code owner May 20, 2024 20:18
@cmmarslender cmmarslender merged commit ee6a0d1 into main May 20, 2024
359 checks passed
@cmmarslender cmmarslender deleted the upload branch May 20, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI changes Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants