Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert final_pubkey: G1Element from main #18063

Merged
merged 1 commit into from
May 22, 2024

Conversation

Quexington
Copy link
Contributor

During a recent PR, an inadvertent change of adding the type constraint G1Element was made to the signer protocol which is supposed to be key type agnostic. This PR reverts the relevant parts of that change.

@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label May 22, 2024
@Quexington Quexington marked this pull request as ready for review May 22, 2024 16:31
@Quexington Quexington requested a review from a team as a code owner May 22, 2024 16:31
@Quexington Quexington requested a review from arvidn May 22, 2024 16:32
@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label May 22, 2024
@cmmarslender cmmarslender merged commit ba4b377 into main May 22, 2024
361 of 362 checks passed
@cmmarslender cmmarslender deleted the quex.revert_g1element_bytes_swap branch May 22, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants