Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] use binary fields in block_store table #9454

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 3, 2021

This patch updates the v2 database schema to use binary fields instead if hex in the block_store table. This reduces the size of the table a little bit. Most of this table is made up of serialized clvm code, which is already stored as binary.

These changes are best reviewed hiding white space changes.

test v1 v2 v2 / v1
table size 2420 MB 2413 MB 99.7%

This change in size may seem insignificant relative to the size of the change. however, most of the code change is mostly related to making any distinction between v1 and v2, and there are more significant changes to be made where it's required to distinguish v1 from v2.

@arvidn arvidn force-pushed the binary-block-store-fields branch 4 times, most recently from 6ff49c0 to 5708cc3 Compare December 3, 2021 21:09
@arvidn arvidn marked this pull request as ready for review December 5, 2021 20:34
@wjblanke wjblanke merged commit a97b03a into main Dec 6, 2021
@wjblanke wjblanke deleted the binary-block-store-fields branch December 6, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants