Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build action on push to main #41

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

jayrevolinskyjr
Copy link
Contributor

@jayrevolinskyjr jayrevolinskyjr commented Mar 3, 2023

This resolves part A of our subtask from here.

  • A. Enable the Build job to run on push to main.
  • B. Get the linter in for all PRs (in progress)
  • C. Clean up all linter issues
  • D. Add a GitHub Action status badge to the README (and remove final bit of Travis CI in Readme)

Which then resolves one part of the task required for Issue 19 .

  • Remove all dependencies on Travis CI
  • Add a GitHub Action workflow to verify a successful build of the project. Should be triggered by all pull requests.
  • Add a GitHub Action workflow to perform static analysis of all pull requests.
  • Add a GitHub Action status badge to README.md with the current build status of the main branch using the new CI workflow

Copy link
Contributor

@ysiddhapura ysiddhapura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jayrevolinskyjr jayrevolinskyjr added the DevOps Concerns developer operations label Mar 4, 2023
@Jooms
Copy link
Contributor

Jooms commented Mar 6, 2023

Looks good to me.

Remember to use the "approve" option when you perform a review of his PR (if it looks good to you). He can't merge until at least two of us have.

Copy link
Contributor

@ysiddhapura ysiddhapura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to Me!

Copy link
Contributor

@Anoushka444 Anoushka444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved.

@jayrevolinskyjr jayrevolinskyjr merged commit bac7997 into main Mar 6, 2023
@jayrevolinskyjr jayrevolinskyjr deleted the push_build_action branch March 6, 2023 02:36
briswells pushed a commit that referenced this pull request Mar 23, 2023
This resolves part A of our subtask from
[here](#19 (comment)).

- [x] A. Enable the Build job to run on push to main.
- [ ] B. Get the linter in for all PRs (in progress)
- [ ] C. Clean up all linter issues
- [ ] D. Add a GitHub Action status badge to the README (and remove
final bit of Travis CI in Readme)

Which then resolves one part of the task required for Issue
[19](#19 (comment))
.

- [ ] Remove all dependencies on Travis CI
- [x] Add a GitHub Action workflow to verify a successful build of the
project. Should be triggered by all pull requests.
- [x] Add a GitHub Action workflow to perform static analysis of all
pull requests.
- [ ] Add a GitHub Action status badge to README.md with the current
build status of the main branch using the new CI workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Concerns developer operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants