-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build action on push to main #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Remember to use the "approve" option when you perform a review of his PR (if it looks good to you). He can't merge until at least two of us have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to Me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes approved.
This resolves part A of our subtask from [here](#19 (comment)). - [x] A. Enable the Build job to run on push to main. - [ ] B. Get the linter in for all PRs (in progress) - [ ] C. Clean up all linter issues - [ ] D. Add a GitHub Action status badge to the README (and remove final bit of Travis CI in Readme) Which then resolves one part of the task required for Issue [19](#19 (comment)) . - [ ] Remove all dependencies on Travis CI - [x] Add a GitHub Action workflow to verify a successful build of the project. Should be triggered by all pull requests. - [x] Add a GitHub Action workflow to perform static analysis of all pull requests. - [ ] Add a GitHub Action status badge to README.md with the current build status of the main branch using the new CI workflow
This resolves part A of our subtask from here.
Which then resolves one part of the task required for Issue 19 .