Adjust files directory sub-folder permissions after site install.

[adamzimmermann]

The site install process was creating sites/mysite/files/styles and sites/mysite/files/media-icons and setting their ownership to the user who ran the site install, which was root in my case.

This fixes the ownership on those directories so image styles can be generated without an error (original impetus for this change).

After testing this I realized that we need to make this not perform the action on hidden files. .htaccess is being changed and it should not be. Fix for that to follow.

Current: -rwxrwx--- 1 www-data root 543 Jan 16 21:54 .htaccess
Correct: -r--r--r-- 1 root root 543 Jan 16 03:35 .htaccess

I have thus far been unable to find a way to do this with the tools available.

• https://docs.ansible.com/ansible/latest/modules/file_module.html#examples

[markdorison]

I guess this only occurs when installing with config since that is how the media module will be installed? What if someone is installing with a profile other than minimal?

[markdorison]

I wonder if we can remove the other similar instance of this and then ditch the when on this task so that it runs every time.

[adamzimmermann]

I guess this only occurs when installing with config since that is how the media module will be installed? What if someone is installing with a profile other than minimal?

I'm not sure where you are going with this. Let's discuss on the coffee zoom.

I wonder if we can remove the other similar instance of this and then ditch the when on this task so that it runs every time.

Let's discuss this on coffee zoom too.

[adamzimmermann]

Discussed and decided to use an array of subdirectory names to avoid altering other files.

[adamzimmermann]

root@drupal:/var/lib/tugboat/web/sites/mysite/files# ls -la
total 4
drwxrwx--- 4 www-data root  56 Jan 17 18:49 .
dr-xr-xr-x 3 root     root  39 Jan 17 18:48 ..
-r--r--r-- 1 root     root 543 Jan 17 18:49 .htaccess
drwxrwx--- 3 www-data root  21 Jan 17 18:49 media-icons
drwxrwx--- 2 www-data root   6 Jan 17 18:49 styles

The latest approach seems to be working well.

[adamzimmermann]

@markdorison I added back the step to set the files directory permissions, as I figured we should set the parent directory permissions and not just the sub-directories that we specify.