Fetch payload in AsyncTask #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
requested changes
Aug 6, 2019
.../main/java/com/chuckerteam/chucker/api/internal/ui/transaction/TransactionPayloadFragment.kt
Outdated
Show resolved
Hide resolved
|
You can use this Charles rewrite rule: Plus you need to remove SSL to let it work properly here: |
added 3 commits
August 7, 2019 12:58
To avoid the formating of json or xml stalling the UI, the payload will be loaded and formatted in an async task instead. Fixes ChuckerTeam#55
redwarp
force-pushed
the
fetch_payload_data_in_async_task
branch
from
7c85675
to
141d730
Compare
|
Verified with a big query that it actually solves the issue. |
cortinico
approved these changes
Aug 7, 2019
.../main/java/com/chuckerteam/chucker/api/internal/ui/transaction/TransactionPayloadFragment.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/chuckerteam/chucker/api/internal/ui/transaction/TransactionPayloadFragment.kt
Outdated
Show resolved
Hide resolved
cortinico
approved these changes
Aug 7, 2019
This was referenced Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the formating of json or xml stalling the UI, the payload will be loaded and formatted in an async task instead.
Fixes #55