Fix for null values being omitted in the parsed body #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redwarp
approved these changes
Aug 9, 2019
cortinico
added a commit
that referenced
this pull request
Aug 9, 2019
cortinico
added a commit
that referenced
this pull request
Aug 12, 2019
* Updating Readme and Screenshots for 3.0.0 * Updating Changelog for 3.0.0 * Add an extra line to the summary of 3.0.0 * Make sure PRs are in a bullet list * Add the Changelog link in the README file * Adding TOC to README * Adding the migration guide * Fixed link to CHANGELOG document * Fixed Migrating from 2.x guide * Adding Migration section * Adding #81 to the Changelog of 3.0.0 * Integrating @macisamuele feedback into the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like when we're parsing the JSON body for pretty printing we're actually omitting nulls.
This PR fixes this plus I've attached some JUnit tests to make sure all works fine.
Fixes #80