Switched from webhook to oauth token to allow channel customization #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is primarily an example in code. I'm happy to rework it off #160 if you would prefer |
|
Code should be in V4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got to update the documentation
This addresses #77
I've switched the code to use the app's oauth token as there is no longer a webhook I've defaulted the channel to
#generalas as it's the only one I can guarantee would be available in slack, so channel is effectively a mandatory field.The code has switched but I haven't amended the documentation. As this is a breaking change I'd like to get some feedback before I send time on the documentation.
Please let me know if you'd be likely to accept this PR (and I'll go through the documentation), or if this is not a direction you want to take (and we can close this PR).
Checklist
Motivation, issues
Description