Add in XML definition #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annegentle
requested changes
Dec 29, 2017
labs/coding-101-rest-basics-ga/2.md
Outdated
| @@ -40,4 +40,6 @@ In this example, you request the list of hosts, and that information is returned | |||
|
|
|||
| (<a href="http://www.json.org/" target="_blank">JSON</a> -- JavaScript Object Notation, is a lightweight text-based open standard designed for human-readable data interchange.) | |||
|
|
|||
| (<a href="http://https://www.w3schools.com/xml/xml_whatis.asp/" target="_blank">XML</a> -- Extensible Markup Language, a language designed to store and transport data.) | |||
There was a problem hiding this comment.
There's a double http then https here, plus I think you can delete the end slash /. And usually I see the acronym spelled out with a capital X, like eXtensible.
Holler if you want help with the git commit --amend and then git push.
annegentle
requested changes
Dec 30, 2017
labs/coding-101-rest-basics-ga/2.md
Outdated
| @@ -40,6 +40,6 @@ In this example, you request the list of hosts, and that information is returned | |||
|
|
|||
| (<a href="http://www.json.org/" target="_blank">JSON</a> -- JavaScript Object Notation, is a lightweight text-based open standard designed for human-readable data interchange.) | |||
|
|
|||
| (<a href="http://https://www.w3schools.com/xml/xml_whatis.asp/" target="_blank">XML</a> -- Extensible Markup Language, a language designed to store and transport data.) | |||
| (<a href="https://www.w3schools.com/xml/xml_whatis.asp/" target="_blank">XML</a> -- eXtensible Markup Language, a language designed to store and transport data.) | |||
There was a problem hiding this comment.
Sorry, this link gives a 404 with that trailing / - change https://www.w3schools.com/xml/xml_whatis.asp/ to https://www.w3schools.com/xml/xml_whatis.asp and it works.
annegentle
approved these changes
Jan 3, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added XML link with short description https://www.w3schools.com/xml/xml_whatis.asp
@annegentle
Fixes #5