Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore saving TMPE metadata if there are no networks. #1505

Merged
merged 2 commits into from
Apr 3, 2022
Merged

ignore saving TMPE metadata if there are no networks. #1505

merged 2 commits into from
Apr 3, 2022

Conversation

kianzarrin
Copy link
Collaborator

fixes #1313
Added null guard for when there is no networks no need to save any asset data in such situations anyway
Ignore white space when reviewing.

test save building with sub-building and no networks: PASS
no on screen error
log shows:

Debug 1,316.7875336: AssetDataExtension.OnAssetSavedImpl(): No segments to record.

@kianzarrin kianzarrin added BUG Defect detected Asset Editor Issue related to TM:PE support in content editors labels Apr 2, 2022
@kianzarrin kianzarrin self-assigned this Apr 2, 2022
originalfoo
originalfoo approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

Not tested in editor.

@originalfoo originalfoo added this to the 11.6.5.2 milestone Apr 2, 2022
krzychu124
krzychu124 approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, what about placing such building, assuming you've modified settings with TM:PE in the main building?

@kianzarrin
Copy link
Collaborator Author

What about placing such building

If there are no networks then there are no metadata. So TMPE is not involved when placing such buildings.

@kianzarrin kianzarrin merged commit 1c31daf into master Apr 3, 2022
@kianzarrin kianzarrin deleted the 1313-save-building branch April 3, 2022 06:20
@originalfoo originalfoo mentioned this pull request Apr 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzychu124 krzychu124 krzychu124 approved these changes

@originalfoo originalfoo originalfoo approved these changes

@kvakvs kvakvs Awaiting requested review from kvakvs

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

Assignees

@kianzarrin kianzarrin

Labels
Asset Editor Issue related to TM:PE support in content editors BUG Defect detected
Projects
None yet
Milestone
11.6.5.2
Development

Successfully merging this pull request may close these issues.

Exception on saving an asset in Asset Editor ~~if it is not an intersection~~
3 participants
@kianzarrin @originalfoo @krzychu124