-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernise IsStartNode()
#1506
Modernise IsStartNode()
#1506
Conversation
Takes a `nodeId` instead of `startNode` then determine if it's start node for `segmentId`.
we also have |
I assume you mean I couldn't find any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then I kinda like this code change
none -> silent
- Added some xmldoc - Improved consistency in file - Suppressed some warnings
bump :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, didn't notice problems
Replaces obsolete
ExtSegmentManager.IsStartNode()
withNetSegment
extensions - eitherIsStartnode()
IsStartNode()
(always returns a bool) orIsStartNode()
GetRelationToNode()
(may returnnull
if node not attached to segment) as applicable.Additionally, updates a few encountered
for
loops likefor (int i = 0; i < 8; ++i)
to more descriptivefor (int segmentIndex = 0; segmentIndex < Constants.MAX_SEGMENTS_OF_NODE; ++segmentIndex)
.Small number of other minor tweaks - eg. to replace some other obsolete stuff in proximity/relation to the main task.
Probably has a lot of overlap with stalled PR #1272.