DropDownOption

[kianzarrin]

fixes: #1510 . No functional changes.

• Moved some shared code to the base class.
• defined generic DropDownOption that can handle any integer enum (maybe I should assert).
• defined KeyAttribute that allows us to put the translations directly on the enum members.
• All drop drowns use the new DropDownOption.

[kianzarrin]

I am yet to test this.

[kianzarrin]

test works. but what is the deal with the tooltip?

EDIT: fixed

[kianzarrin]

fixed it.

[originalfoo]

@kianzarrin Could you also take a look at the tooltip for sliders at some point (out of scope for this PR): Should show current slider value but CO UI is very unreliable at updating the tooltip. Alternative would be custom slider component eg. something like Quistar's Tree Anarchy mod?

[originalfoo]

Also noticed 2 drop-downs not yet converted in GeneralTab_LocalisationGroup.cs:

• language
• road sign theme

[kianzarrin]

@aubergine10 Also noticed 2 drop-downs not yet converted in GeneralTab_LocalisationGroup.cs

They where not covered by OptionsManager so fixing them does not contribute toward #363.

they don't have enum so they may need special code so lets deal with them in another PR.

[originalfoo]

SliderOption has an extraneous ReadOnly getter/setter (line 79) that can likely be removed as that's now included in SerializableUIOptionBase.

[originalfoo]

LGTM 👍

Built from source as DEBUG and RELEASE. Tested from main menu, and in-game.

[originalfoo]

bumping for great justice