Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAN-1525 Projects widget #7999

Merged
merged 106 commits into from
Jun 4, 2024
Merged

TAN-1525 Projects widget #7999

merged 106 commits into from
Jun 4, 2024

Conversation

luucvanderzee
Copy link
Contributor

@luucvanderzee luucvanderzee commented May 24, 2024 •
edited
Loading

Changelog

Added

  • 'Published projects' widget in report builder

@notion-workspace Notion Workspace
Copy link

Projects completed widget

@luucvanderzee luucvanderzee changed the base branch from master to TAN-1900-participation-widget May 24, 2024 09:11
@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented May 24, 2024 •
edited
Loading

Warnings
⚠️ The PR title contains no Jira issue key (case-sensitive)
⚠️ The branch name contains no Jira issue key (case-sensitive)
Messages
📖 Changelog provided 🎉
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against 8904685

luucvanderzee and others added 22 commits May 24, 2024 13:03
@luucvanderzee luucvanderzee requested a review from adessy May 27, 2024 16:20
adessy
adessy approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@adessy adessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just made a few minor comments — feel free to disregard them 🙂

...ainers/Admin/reporting/components/ReportBuilder/Widgets/ProjectsWidget/ProjectsCard/utils.ts Outdated Show resolved Hide resolved
...iners/Admin/reporting/components/ReportBuilder/Widgets/ProjectsWidget/ProjectsCard/index.tsx Outdated Show resolved Hide resolved
.../Admin/reporting/components/ReportBuilder/Widgets/ProjectsWidget/ProjectsCard/ProjectRow.tsx Show resolved Hide resolved
.../Admin/reporting/components/ReportBuilder/Widgets/ProjectsWidget/ProjectsCard/ProjectRow.tsx Outdated Show resolved Hide resolved
.../Admin/reporting/components/ReportBuilder/Widgets/ProjectsWidget/ProjectsCard/ProjectRow.tsx Outdated Show resolved Hide resolved
front/app/api/graph_data_units/responseTypes/ProjectsWidget.ts Show resolved Hide resolved
back/lib/time_boundaries_parser.rb Outdated Show resolved Hide resolved
back/engines/commercial/report_builder/app/services/report_builder/queries/projects.rb Outdated Show resolved Hide resolved
back/engines/commercial/report_builder/app/services/report_builder/queries/projects.rb Outdated Show resolved Hide resolved
back/engines/commercial/report_builder/app/services/report_builder/queries/projects.rb Show resolved Hide resolved
luucvanderzee and others added 25 commits June 3, 2024 20:03
@luucvanderzee
Improve query according to Adrien's suggestion
04bdb63
@luucvanderzee
Extract STALENESS_PERIOD variable
3643d3c
@luucvanderzee
Filter out non-published projects in BE
f01c6e3
@luucvanderzee
Project period copy
525bddd
@luucvanderzee
Time boundary parser changes
c2f0b2d
Translations updated by CI (extract-intl)
c444ba3
@luucvanderzee
Merge branch 'TAN-1525-projects-widget' into TAN-1529-strategic-repor…
b5077bc 
…t-template
@adessy
[TAN-1641] Remove remaining references to "active users"
1ef8599
@luucvanderzee
_
2404f6a
@luucvanderzee
Merge branch 'TAN-1525-projects-widget' into TAN-1529-strategic-repor…
32bf22c 
…t-template
@luucvanderzee
Make design methods used widget look a bit nicer on A4
0e6aa92
@luucvanderzee
Replace lorem ipsum by generic copy
ddd0fc0
@luucvanderzee
Quarters projects -> projects
3ff4f1a
@luucvanderzee
_
14693a3
@luucvanderzee
Move magic numbers
307fd36
@luucvanderzee
Fix formatting
464b13a
@luucvanderzee
_
f1a47eb
@luucvanderzee
Create a project report -> Create a report
8faf7e3
Translations updated by CI (extract-intl)
83b219b
@luucvanderzee
Remove console override
fa7ed9f
@luucvanderzee
Merge branch 'TAN-1529-strategic-report-template' into TAN-1902-rando…
1006722 
…m-fixes
@luucvanderzee
Merge branch 'TAN-1902-random-fixes' into TAN-1641-participants-cleanup
54c1e73
@luucvanderzee
Merge pull request #8080 from CitizenLabDotCo/TAN-1641-participants-c…
2ef6294 
…leanup

TAN-1641 Participants cleanup
@luucvanderzee
Merge pull request #8053 from CitizenLabDotCo/TAN-1902-random-fixes
953caa8 
TAN-1902 Report builder random fixes
@luucvanderzee
Merge pull request #8040 from CitizenLabDotCo/TAN-1529-strategic-repo…
8904685 
…rt-template

TAN-1529 Strategic report template
@luucvanderzee luucvanderzee merged commit 06e152b into TAN-1900-participation-widget Jun 4, 2024
@luucvanderzee luucvanderzee deleted the TAN-1525-projects-widget branch June 4, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adessy adessy adessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luucvanderzee @cl-dev-bot @adessy