-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
I see your |
@slipo Could you add test coverage? |
just saw this so gonna drop some comments:
|
@snowypowers I think we can merge this for now and track against changes to neon-js and neondb. Eventually, I think project will actually invert with there being neo-js nodes running which neon-js interfaces with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Sorry it took so long to get in!
Description
This adds a wrapper class over neon-js to provide light wallet support. A few notes:
Because the required functionality for a light wallet isn't really supported by core neo nodes and requires accessing CoZ sites running NeonDB, I do believe @lllwvlvwlll's guidance was right and we should offload this integration to neon-js.
Local storage wallet support can be built on top of this as an alternation data access method. We have transaction history and balance support already from local data. One open question is in what format to we return the data. I would argue we should return data the same as neon-js. I'm doing this for now.
Some of the methods used by neon-js return or use as parameters internal classes such as "Transactions" ... we don't quite have the equivalent right now and it would be a bit of work to implement them. What to do here should also be discussed.
Motivation and Context
Wallet support: #78
Integrate neon-js: #101
How Has This Been Tested?
For now, there's an example script that shows how it works.
Screenshots (if appropriate):
Types of changes
Checklist: