Fix neo-scan and use latest version #19
Conversation
|
Good moves, adrienmo. You are good on it! 🗡️ |
…w image allowing running at localhost address
|
The new version now run on : http://localhost:4000 or
|
|
You can now additionally configure the host name: This way, if you're setting up a central private testnet for an event, you can add your IP (let's say 123.4.5.6 for example) and everyone can connect to neoscan, the nodes (via neoscan) and the notifications-db with: If you don't want to allow them access to the notifications server f.e., you can just leave out that part of the command |
|
Just wanted to clarify that you can do this with |
There was a problem hiding this comment.
Really nice work!
Small comment around JSON formatting - easy fix.
Can you also please amend any Docker commands within the Makefile.
https://github.com/CityOfZion/neo-local/blob/master/Makefile
custom-config.json
Outdated
| "RegisterTransaction": 10000 | ||
| } | ||
| }, | ||
|
|
There was a problem hiding this comment.
Remove newline.
Easiest to run through a JSON linter, such as https://jsonlint.com
|
@revett linted the json, no changes to any docker commands. This works out of the box with docker-compose and make 😆 |
Rather than building a neoscan image, the docker-compose can refer directly to a production ready container that supports custom variables to configure the host/nodes/notifications server.
For this reason the neo-scan folder is now useless.
One neo-python container in the docker network was added to act as the local notification server.
custom-config.json for the notification server was copied from the privnet example but the ip of nodes where changed (--privnet and --host options cannot be used together unfortunately).