Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify list parameters handling in tx build #255

Closed
wants to merge 192 commits into from
Closed

Modify list parameters handling in tx build #255

wants to merge 192 commits into from

Conversation

NeoDashboard
Copy link
Contributor

Modify list parameters handling to remove useless OpCodes and reduce fees.

* add missing int32 serialization

* fix documentation typo

* cleanup a bit and increase coverage
* add manifest support (#7)

* add manifest support

* fix requirement

* Feature nef (#8)

* Remove mpmath dependency and fix py3.8 warning in ECC module (#26)

* rebrand

* close #3

* Update and rename GetBlockDataPayload

* Updates for requesting headers via GetBlocksByIndexPayload

* Merge transaction sender and cosigner (#19)

* add test for NEO issue #1672 (#20)

* correct test name

* refactor serializable (#27)

* Add documentation publish step to travis (#28)

* Limit documentation publishing step to master only (#29)

* Prepare for release (#31)
Smart contracts everywhere...
@NeoDashboard NeoDashboard mentioned this pull request Mar 28, 2023
Copy link
Member

@ixje ixje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor things

  1. Please add a test case for coverage. Can be as simple as this

    neo-mamba/tests/test_vm.py

    Lines 141 to 147 in bcb1ef1

    def test_emit_push_dict(self):
    data = {"a": 123, "b": 456}
    sb = vm.ScriptBuilder()
    sb.emit_push(data)
    expected = "007b0c016101c8010c016212be"
    self.assertEqual(expected, sb.to_array().hex())
  2. don't change the version numbers. That will be done during a release

The rest looks good :)

@coveralls
Copy link

coveralls commented Mar 28, 2023

Coverage Status

Coverage: 80.972% (-0.03%) from 81.0% when pulling 38fe835 on NeoDashboard:master into bcb1ef1 on CityOfZion:master.

CHANGELOG.rst Outdated Show resolved Hide resolved
@ixje
Copy link
Member

ixje commented Apr 3, 2023

Do you still want to continue on this?

@NeoDashboard NeoDashboard closed this by deleting the head repository Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants