-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify list parameters handling in tx build #255
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup circle-ci
* add manifest support (#7) * add manifest support * fix requirement * Feature nef (#8) * Remove mpmath dependency and fix py3.8 warning in ECC module (#26) * rebrand * close #3 * Update and rename GetBlockDataPayload * Updates for requesting headers via GetBlocksByIndexPayload * Merge transaction sender and cosigner (#19) * add test for NEO issue #1672 (#20) * correct test name * refactor serializable (#27) * Add documentation publish step to travis (#28) * Limit documentation publishing step to master only (#29) * Prepare for release (#31)
Smart contracts everywhere...
* neo-project/neo#2295 * neo-project/neo#2290 * neo-project/neo#2292 * neo-project/neo#2296 * neo-project/neo#2301 * neo-project/neo#2298 * neo-project/neo#2312 * neo-project/neo#2300 * neo-project/neo#2333 * neo-project/neo#2337 * neo-project/neo#2331 * neo-project/neo#2332 * neo-project/neo#2343 * neo-project/neo#2339 * neo-project/neo#2350 * neo-project/neo#2351 * neo-project/neo#2353 * neo-project/neo#2356 * neo-project/neo#2375 * neo-project/neo#2377 * neo-project/neo#2379 * https://github.com/neo-project/neo/pull/2392/files * neo-project/neo#2400 * audit updates * refactor and bump VM requirement
Closed
ixje
requested changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor things
- Please add a test case for coverage. Can be as simple as this
Lines 141 to 147 in bcb1ef1
def test_emit_push_dict(self): data = {"a": 123, "b": 456} sb = vm.ScriptBuilder() sb.emit_push(data) expected = "007b0c016101c8010c016212be" self.assertEqual(expected, sb.to_array().hex()) - don't change the version numbers. That will be done during a release
The rest looks good :)
ixje
reviewed
Mar 28, 2023
Do you still want to continue on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify list parameters handling to remove useless OpCodes and reduce fees.