This repository has been archived by the owner on Sep 10, 2019. It is now read-only.
Merkletree Trim fix + add tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update docstrings
localhuman
approved these changes
Jan 7, 2018
|
correct, |
|
May be used in the future. Anyways, looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address?, or what feature is it adding?
Addressing #19
How did you solve this problem?
write tests
How did you make sure your solution works?
make lintmake test && make coverageDid you add any tests?
yes
Are there any special changes in the code that we should be aware of?
changed the scope of
__TrimNodeto_TrimNodebecause otherwise it would not be testable.