This repository has been archived by the owner on Sep 10, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address?, or what feature is it adding?
This one has been bothering me for a while so it's about time to clarify it. The error message when providing data that is not long enough is not self explanatory.
both produce
A more verbose error message can clarify what is wrong about the data.
How did you solve this problem?
make the error message more verbose.
Case 1
It's immediately clear I'm not providing enough data
Case 2
It becomes clear that the format I'm providing data in isn't valid and I have to convert it to raw bytes.
How did you make sure your solution works?
ran some manual tests in Ipython.
Did you add any tests?
no
Are there any special changes in the code that we should be aware of?
no