Skip to content
This repository was archived by the owner on Sep 10, 2019. It is now read-only.

Conversation

ambethia
Copy link
Contributor

@ambethia ambethia commented Jan 14, 2018

What current issue(s) does this address?, or what feature is it adding?

Address version is hard coded to 23, but is intended to be configurable in protocol.json.

I'm working with a neo fork that uses a different address version.

How did you solve this problem?

Added a variable ADDRESS_VERSION to Helper module that can be overridden.

How did you make sure your solution works?

I added a unit test to demonstrate.

Did you add any tests?

Of course!

Are there any special changes in the code that we should be aware of?

I'll be opening a PR for neo-python that updates this from Settings/protocol.json

Copy link
Collaborator

@localhuman localhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like pycodestyle is unhappy

@metachris
Copy link
Contributor

Looks good, thanks 👍

Just the code style has one minor issue, you can see it by running make lint. Please fix it, then i'll merge and create a new release so you can use it with neo-python.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b69306f on ambethia:master into a0939eb on CityOfZion:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling b69306f on ambethia:master into a0939eb on CityOfZion:master.

@metachris metachris merged commit 80eed1f into CityOfZion:master Jan 15, 2018
@metachris
Copy link
Contributor

ty 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants