This repository was archived by the owner on Sep 10, 2019. It is now read-only.
Allow change to address version #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address?, or what feature is it adding?
Address version is hard coded to
23
, but is intended to be configurable inprotocol.json
.I'm working with a neo fork that uses a different address version.
How did you solve this problem?
Added a variable
ADDRESS_VERSION
toHelper
module that can be overridden.How did you make sure your solution works?
I added a unit test to demonstrate.
Did you add any tests?
Of course!
Are there any special changes in the code that we should be aware of?
I'll be opening a PR for
neo-python
that updates this from Settings/protocol.json