Skip to content
This repository was archived by the owner on Nov 15, 2021. It is now read-only.

Conversation

metachris
Copy link
Contributor

What current issue(s) does this address, or what feature is it adding?

Updated the code to work with the new version of prompt-toolkit, which in v2.x had a few breaking changes, in particular around the Style and the prompt function signature: https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/CHANGELOG.

See also:

How did you solve this problem?

Updating the code based on the prompt-toolkit examples.

The only thing I could not migrate was the bottom toolbar styling. It seems the new version doesn't allow foreground colors in the bottom toolbar anymore: https://github.com/CityOfZion/neo-python/blob/deps-prompt/neo/bin/prompt.py#L171

It looks like this now:

screen shot 2018-06-26 at 12 16 23

How did you make sure your solution works?

Manual tests

Are there any special changes in the code that we should be aware of?

No, except the changed bottom toolbar styling

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@localhuman
Copy link
Collaborator

Looks good! I'm ok with the different bottom toolbar styling-

@localhuman localhuman merged commit 606b8fe into development Jun 27, 2018
@localhuman localhuman deleted the deps-prompt branch June 27, 2018 23:25
@localhuman localhuman restored the deps-prompt branch June 27, 2018 23:44
@localhuman
Copy link
Collaborator

Actually, after playing around with this for a bit I'm noticing some odd things such as: <prompt_toolkit.styles.style.Style object at 0x10fc36f60> being printed after any command using FormattedText. Will revert for now

metachris pushed a commit that referenced this pull request Jun 29, 2018
Dependency update: prompt-toolkit
@metachris metachris mentioned this pull request Jun 29, 2018
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants