This repository was archived by the owner on Nov 15, 2021. It is now read-only.
Dependency update: prompt-toolkit #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
Updated the code to work with the new version of prompt-toolkit, which in v2.x had a few breaking changes, in particular around the Style and the prompt function signature: https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/CHANGELOG.
See also:
How did you solve this problem?
Updating the code based on the prompt-toolkit examples.
The only thing I could not migrate was the bottom toolbar styling. It seems the new version doesn't allow foreground colors in the bottom toolbar anymore: https://github.com/CityOfZion/neo-python/blob/deps-prompt/neo/bin/prompt.py#L171
It looks like this now:
How did you make sure your solution works?
Manual tests
Are there any special changes in the code that we should be aware of?
No, except the changed bottom toolbar styling
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)