This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Fix ByteArray equals #997
Merged
Fix ByteArray equals #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
Audit of Testnet block
2728887showed a deviation in gas consumption due to failed comparison between a single elementByteArrayand an integer.How did you solve this problem?
ensure that the
Equalsmethod ofByteArraytries to compare against anotherByteArraytype instead of whatever type it might be.How did you make sure your solution works?
audit of the block now passes
Are there any special changes in the code that we should be aware of?
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)