Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Fix ByteArray equals #997

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Fix ByteArray equals #997

merged 1 commit into from
Jul 30, 2019

Conversation

ixje
Copy link
Member

@ixje ixje commented Jul 30, 2019

What current issue(s) does this address, or what feature is it adding?
Audit of Testnet block 2728887 showed a deviation in gas consumption due to failed comparison between a single element ByteArray and an integer.

How did you solve this problem?
ensure that the Equals method of ByteArray tries to compare against another ByteArray type instead of whatever type it might be.

How did you make sure your solution works?
audit of the block now passes

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 85.267% when pulling 56095c4 on ixje:fix-bytearray-equals into 9e8421a on CityOfZion:development.

@ixje ixje merged commit a7993c2 into CityOfZion:development Jul 30, 2019
@ixje ixje deleted the fix-bytearray-equals branch July 31, 2019 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants