Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tx): core.signTransaction to check for privateKey #122

Merged
merged 4 commits into from
Jan 2, 2018
Merged

fix(tx): core.signTransaction to check for privateKey #122

merged 4 commits into from
Jan 2, 2018

Conversation

snowypowers
Copy link
Member

  • Implement a simple check for privateKey before signing. Encountered case where WIF was inserted instead and resulted in wrong signature.

  • Expanded Transaction.sign to accept Account and WIF

  • write tests for Transaction.sign

@snowypowers snowypowers merged commit 0b157ec into CityOfZion:dev Jan 2, 2018
@mhuggins
Copy link
Contributor

mhuggins commented Jan 2, 2018

Looks good to me, thanks!

@snowypowers snowypowers deleted the fix/sign-wif branch January 9, 2018 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snowypowers @mhuggins