Fixed missing frame lines in ReadCode #1759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
Noticed that in the sketch design file there should be markers in the send modal QR scan rubric AND that there are related DOM elements in the code, but the markers do not appear.
What problem does this PR solve?
How did you solve this problem?
How did you make sure your solution works?
Manually gazed at it like a madman.
Are there any special changes in the code that we should be aware of?
Since Sass
@extend
is already used for this, I kicked it up a notch making it into placeholder classes (.frameLine
->%frameLine
) which is better for perf in this case.It all comes down to this. Ain't it nice? 😬