-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented redux on ReadCode/SendModal #1761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvd-schwrtz
approved these changes
Dec 20, 2018
Pull Request Test Coverage Report for Build 5478
💛 - Coveralls |
ranbena
commented
Dec 20, 2018
evgenyboxer
reviewed
Dec 21, 2018
ranbena
force-pushed
the
fix/readcode-redux
branch
from
December 21, 2018 07:11
d55f84a
to
e3ff823
Compare
ranbena
force-pushed
the
fix/readcode-redux
branch
from
December 21, 2018 07:55
e3ff823
to
3b48206
Compare
ranbena
force-pushed
the
fix/readcode-redux
branch
from
December 21, 2018 11:00
3b48206
to
b889f35
Compare
1 task
This looks and works great excellent job @ranbena |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
This is a part of a few PRs to better the QR Scan implementation.
What problem does this PR solve?
The Send Modal code is a bit convoluted imho and now made simpler.
It handles notification errors by itself and lacks in static typing.
How did you solve this problem?
withProgress
to be used by the QR Scanner (upcoming commit depending on this one).How did you make sure your solution works?
Manually tested. No change in functionality nor regression.
Go to Send -> Enter QR Code -> try it out
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?