Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Adds trailing commas #1764

Merged
merged 1 commit into from
Dec 22, 2018
Merged

Conversation

comountainclimber
Copy link
Member

What current issue(s) from Trello/Github does this address?
Ports over the work that @ranbena did here => #1763

What problem does this PR solve?

How did you solve this problem?

How did you make sure your solution works?

Are there any special changes in the code that we should be aware of?

Is there anything else we should know?

  • Unit tests written?

@comountainclimber comountainclimber changed the title adds trailing commas thank you @ranbena feature: Adds trailing commas Dec 22, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5525

  • 8 of 45 (17.78%) changed or added relevant lines in 34 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.676%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/actions/contactsActions.js 0 1 0.0%
app/actions/icoTokensActions.js 0 1 0.0%
app/actions/networkActions.js 0 1 0.0%
app/actions/pricesActions.js 0 1 0.0%
app/components/Blockchain/Transaction/index.js 0 1 0.0%
app/components/Contacts/ContactForm/ContactForm.jsx 0 1 0.0%
app/components/Contacts/ContactForm/index.js 0 1 0.0%
app/components/Modals/AddContactModal/index.js 0 1 0.0%
app/components/Modals/TokenModal/TokenModal.jsx 0 1 0.0%
app/components/Modals/TokenModal/index.js 0 1 0.0%
Totals Coverage Status
Change from base Build 5521: 0.0%
Covered Lines: 1032
Relevant Lines: 2322

💛 - Coveralls

@comountainclimber comountainclimber merged commit 9ad065b into dev Dec 22, 2018
@comountainclimber comountainclimber deleted the feature/trailing-commas branch December 22, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants