Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react router v4 #290

Merged
merged 4 commits into from
Oct 31, 2017
Merged

Upgrade to react router v4 #290

merged 4 commits into from
Oct 31, 2017

Conversation

evgenyboxer
Copy link
Contributor

@evgenyboxer evgenyboxer commented Oct 31, 2017

What current issue(s) from Trello/Github does this address?
Updating npm packages

What problem does this PR solve?
React router v4 is a major improvement over v2/v3. It will allow us to do greater things declaratively, async routes, animation between routes, and more.

How did you solve this problem?
Followed the migration guide - https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/guides/migrating.md

How did you make sure your solution works?
Checked that all routes worked like before.

Are there any special changes in the code that we should be aware of?
Syncing with redux store will be added in another PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.366% when pulling 7fc8b96 on upgrade-to-react-router-v4 into d549bbe on dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.366% when pulling ef80c94 on upgrade-to-react-router-v4 into d549bbe on dev.

@shawnmclean shawnmclean merged commit 75ce29b into dev Oct 31, 2017
@shawnmclean shawnmclean deleted the upgrade-to-react-router-v4 branch October 31, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants