-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Notification System + CSS Modules (WIP) #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us notification without any animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
Improving notification system + Introduce CSS Modules.
What problem does this PR solve?
The current implementation was lacking types, was not dismissible by default, so you always had to call clearTransaction, could not set a position, and was lacking styling.
This PR brings a new system:
Also, I added CSS Modules, and it works with CSS/SCSS. I made it possible to still load "global" files by having a
.global.scss
as a filename. I did some initial work of moving a lot of the styles into their respective component, created a variables.scss file, and more.How did you solve this problem?
notification
that has functions for each notification -showSuccessNotification(..)
showInfoNotification(..)
etc.<Button>
and<HomeButtonLink>
How did you make sure your solution works?
Currently tests are broken, and I'm working on fixing that. Other than that, the wallet is pretty solid.
I also added some UX goodies to the login pages, like having titles, so they would look similar to other pages + padding fixes.