-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple notifications on page #325
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port in react notification system
evgenyboxer
changed the title
Rework notification system 2
Support for multiple notifications on page
Nov 16, 2017
dvdschwrtz-zz
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
Precursor for the connectivity branch. I needed a way to show multiple notifications on page.
What problem does this PR solve?
Being able to show multiple notifications on page. So for example, you could see a wallet upgrade warning notification, and other notifications (such as the errors/info/etc)
How did you solve this problem?
I have used React Notification System, which is a pretty solid library. I have implemented a light wrapper for it.
How did you make sure your solution works?
Extensive QA
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?
Yes.