Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple notifications on page #325

Merged
merged 26 commits into from
Nov 16, 2017

Conversation

evgenyboxer
Copy link
Contributor

@evgenyboxer evgenyboxer commented Nov 16, 2017

What current issue(s) from Trello/Github does this address?
Precursor for the connectivity branch. I needed a way to show multiple notifications on page.

What problem does this PR solve?
Being able to show multiple notifications on page. So for example, you could see a wallet upgrade warning notification, and other notifications (such as the errors/info/etc)

How did you solve this problem?
I have used React Notification System, which is a pretty solid library. I have implemented a light wrapper for it.

How did you make sure your solution works?
Extensive QA

Are there any special changes in the code that we should be aware of?

Is there anything else we should know?

  • Unit tests written?
    Yes.

screen shot 2017-11-16 at 6 37 04 pm

@evgenyboxer evgenyboxer changed the title Rework notification system 2 Support for multiple notifications on page Nov 16, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.002% when pulling 20346bb on rework-notification-system-2 into 2c7c83f on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.002% when pulling 20346bb on rework-notification-system-2 into 2c7c83f on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.002% when pulling a510d68 on rework-notification-system-2 into 2c7c83f on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 47.002% when pulling 299a84b on rework-notification-system-2 into 2c7c83f on dev.

@dvdschwrtz-zz dvdschwrtz-zz merged commit 405fae7 into dev Nov 16, 2017
@shawnmclean shawnmclean deleted the rework-notification-system-2 branch January 14, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants