Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rht - redeemable hashpuppy token constant #501

Closed
wants to merge 2 commits into from
Closed

rht - redeemable hashpuppy token constant #501

wants to merge 2 commits into from

Conversation

uvmetal
Copy link

@uvmetal uvmetal commented Jan 8, 2018

This adds hashpuppy support for neon-wallet

@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.457% when pulling 7344b73 on phetter:dev into f3507e4 on CityOfZion:dev.

@uvmetal
Copy link
Author

uvmetal commented Jan 9, 2018

Okay so in all honesty I didn't notice that this was a duplicate (nearly). I simply didn't check the existing PRs since I thought there was no way someone would've added it. What a coincidence. This version does have the test token added though.

@weppos
Copy link
Contributor

weppos commented Jan 9, 2018

@phetter FYI the test token doesn't exist, reason I kept it out on purpose.
https://testnet.neotracker.io/asset/2328008e6f6c7bd157a342e789389eb034d9cbc4

}

// MainNet
export const TOKENS = {
DBC: 'b951ecbbc5fe37a9c280a76cb0ce0014827294cf',
RPX: 'ecc6b20d3ccac1ee9ef109af5a7cdb85706b1df9',
QLC: '0d821bd7b6d53f5c2b40e217c6defc8bbe896cf5'
QLC: '0d821bd7b6d53f5c2b40e217c6defc8bbe896cf5',
RHT: '2328008e6f6c7bd157a342e789389eb034d9cbc4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@weppos weppos Jan 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is correct. There are 4 other RTH test tokens that were created after. It looks like they run several tests, without having a final one.

Eg. https://testnet.neotracker.io/asset/f9572c5b119a6b5775a6af07f1cef5d310038f55

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth pinging their team then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought. Not sure if it's really vital. 😄

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was another PR with the same token value that I merged already before I saw these comments. we will remove it when testing if it is not the correct value. I am closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants