Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ciw.random_choice #104

Merged
merged 2 commits into from
Mar 20, 2017
Merged

Improve ciw.random_choice #104

merged 2 commits into from
Mar 20, 2017

Conversation

geraintpalmer
Copy link
Member

  • If using uniform dist: now doesn't use while loop
  • Uses implementation of random.choice from python2
  • Does not use random.choice to ensure equality in Ptyhon 2 and 3
  • Particular improvements for Empirical distributions

@geraintpalmer
Improve ciw.random_choice
4ae70f7 
- If using uniform dist: now doesn't use while loop
- Uses implementation of random.choice from python2
- Does not use random.choice to ensure equality in Ptyhon 2 and 3
- Particular improvements for Empirical distributions
@coveralls
Copy link

coveralls commented Mar 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4ae70f7 on random_sample into 39119d4 on master.

@coveralls
Copy link

coveralls commented Mar 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling ce9b151 on random_sample into 39119d4 on master.

@geraintpalmer geraintpalmer merged commit 1660d56 into master Mar 20, 2017
@geraintpalmer geraintpalmer deleted the random_sample branch April 4, 2017 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geraintpalmer @coveralls