Attach server to individual before calculating the service time #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to attach_server() method:
- Remove the line that updates the service_end_date for the server.
It is removed because we want to do that after get_service_time
is ran for the individual.
Changes to begin_service_if_possible_accept() method:
- Call attach_server method before getting indvidual's service time
- Update server's next_end_service_date at the last line only if the
number of servers are not infinite. This was initially done in the
attach_server method.
- Update docstring
Call attach_server() before get_service_time() and update the server's next_end_service_date attribute for these methods: - begin_interrupted_individuals_service - begin_service_if_possible_change_shift - begin_service_if_possible_release
|
Hey @geraintpalmer. Let me know what you think about these changes 😄 If helpful I can add a subsection on the documentation for server dependent distributions (Probably here) |
|
Hi @11michalis11 this looks good, I'm happy with the change. An example in the documentation about server dependent distributions would be really nice. I think it would be better suited here: https://ciw.readthedocs.io/en/latest/Guides/behaviour/index.html Could you write up an example? I can merge them at the same time then and draft a new release :) Thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in the source code can enable the creation of a custom distribution that is server dependent. Currently when trying to access
ind.serverfrom a custom distribution class (that inherits fromciw.dists.Distribution) the outcome isFalse. That is because the server attaches to the individual after the service time is calculated.The purpose of this PR is to change the order that the
attach_server()method and theget_service_time()method are executed.