Improve Rich Text #124
Merged
Improve Rich Text #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
reviewed
Mar 8, 2025
# Conflicts: # src/main/java/com/cleanroommc/modularui/drawable/text/RichText.java # src/main/java/com/cleanroommc/modularui/drawable/text/RichTextCompiler.java # src/main/java/com/cleanroommc/modularui/screen/ClientScreenHandler.java # src/main/java/com/cleanroommc/modularui/widgets/RichTextWidget.java
brachy84
approved these changes
Oct 2, 2025
brachy84
added a commit
to brachy84/ModularUI2-GTNH
that referenced
this pull request
Oct 11, 2025
* add overloads, methods, and improve rich text * fix off by one trim * no need to translate * increment x by space width * add back translate in ClientScreenHandler * fix --------- Co-authored-by: brachy84 <brachy84@gmail.com> (cherry picked from commit 90d5f2f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an extra draw method for passing in a different text renderer
adds methods for getting last width/height
fix off by one trim
simplify getting hovered element