Workable ray tracing for SchemaWidget #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its need to copy tile before adding to fake world, othsewise TileEntity#world of real tile will become fake world
# Conflicts: # src/main/java/com/cleanroommc/modularui/test/TestTile.java # src/main/java/com/cleanroommc/modularui/widgets/SchemaWidget.java
brachy84
pushed a commit
to brachy84/ModularUI2-GTNH
that referenced
this pull request
Sep 30, 2025
* fix npe * workable ray tracing for SchemaWidget * added testing case of SchemaWidget to TestTile * fix TileEntity#world corrupting by SchemaWidget its need to copy tile before adding to fake world, othsewise TileEntity#world of real tile will become fake world * removed redundant imports * make SchemaRenderer#rayTrace protected, so user can override it if have better impl * fix merge * many improvements * better highlight renderer --------- Co-authored-by: brachy84 <brachy84@gmail.com> (cherry picked from commit a825c97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature which I found in mui was around unusable, so I made my own version.
Its still not ideal, but at least playable.
java_4Fdv3ujQxU.mp4
Also fixed TileEntity#world corrupting.