Fix text alignment not working with TextFieldWidget #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachy84
requested changes
May 27, 2025
src/main/java/com/cleanroommc/modularui/widgets/textfield/TextFieldWidget.java
Outdated
Show resolved
Hide resolved
No. i cant even enter text longer than the field with the change, somehow didnt pick this up in testing looking at it further it appears thats because of this check in if (this.maxWidth < getFontRenderer().getStringWidth(line)) {
return false;
}where returning false stops the text from being inserted into the TextField. not sure how to fix this |
|
going to mark this pr as draft cuz fixing the issue properly is alot more involved than i thought it would be |
|
Unmarking this as draft because testing in game shows everything working and rendering fine even when the field has to scroll |
# Conflicts: # src/main/java/com/cleanroommc/modularui/test/TestTile.java # src/main/java/com/cleanroommc/modularui/widgets/textfield/TextFieldWidget.java
brachy84
approved these changes
Sep 30, 2025
brachy84
added a commit
to brachy84/ModularUI2-GTNH
that referenced
this pull request
Sep 30, 2025
* do the fix * add test * horizontal * fix a few bugs * comment & bool for checking width --------- Co-authored-by: brachy84 <brachy84@gmail.com> (cherry picked from commit 35d0b44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did my testing using TestTile, modifying the
TextFieldWidgets at L249 & L254 to have a.setTextAlignment(Alignment.Center).Before fix
Still on the left despite using
Alignment.CenterAfter fix
Now centered!!