Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly move from
String
keys for widget themes to specializedWidgetThemeKey<T>
.Additionally this pr:
item_slot:player
).:hover
suffix)defaultHeight
anddefaultWidth
properties to widget theme. Note that these have no effect if their respective method is overriden in a widget (f.e. TextWidget).iconColor
property to widget theme. This is applied to icon like textures.Breaking Changes
String
->WidgetThemeKey<T>
: This will break any custom themes in java.WidgetTheme
->WidgetThemeEntry<?>
:WidgetTheme
is replaced with the name class in almost all places inWidget
. The new class holds the standard old widget theme and the new hover widget theme. Any widget that overrides a draw or widget theme method will break.