New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various translation issues #22102

Open
Night-Pryanik opened this Issue Oct 7, 2017 · 6 comments

Comments

2 participants
@Night-Pryanik
Member

Night-Pryanik commented Oct 7, 2017

  • "reload_noise" from jsons isn't translated;
    default
  • Reload menu entry sometimes shifts the bars with no obvious reason. In English everything is fine. It seems that "N" translation is lost somehow;
    default
    default
  • Green default character name header isn't translated;
    default
  • Fangs mutation special attack translation is lost somehow;
    default
  • Translated strings that don't fit in the window seem to lose some symbols;
    default
  • Sometimes strings are colored incorrectly;
    default
    default
  • Attitude is untranslated; status (ellipsis at the right edge) is shifted;
    default
  • Line shifting.
    default

@Night-Pryanik Night-Pryanik changed the title from "reload_noise" from jsons isn't translated to Various translation issues Oct 10, 2017

@Night-Pryanik

This comment has been minimized.

Show comment
Hide comment
@Night-Pryanik

Night-Pryanik Oct 10, 2017

Member

Seems to fix the second issue. Had to lurk through the code for it. Directions must have 5 symbols, e.g. above and south = "UP_S" (UP_S and one whitespace). There can be no good abbreviation for UP, or DN, or CE in other languages, so for example in Russian we chose to translate "UP_S" as "". As you can see, the result has two symbols instead of three symbols in the original text, so we must add missing symbols as whitespaces.

Member

Night-Pryanik commented Oct 10, 2017

Seems to fix the second issue. Had to lurk through the code for it. Directions must have 5 symbols, e.g. above and south = "UP_S" (UP_S and one whitespace). There can be no good abbreviation for UP, or DN, or CE in other languages, so for example in Russian we chose to translate "UP_S" as "". As you can see, the result has two symbols instead of three symbols in the original text, so we must add missing symbols as whitespaces.

@AMurkin

This comment has been minimized.

Show comment
Hide comment
@AMurkin

AMurkin Oct 10, 2017

Contributor

no. 4 - extract_mutation in extract_json_strings.py counts attacks as objects, but they also can be arrays of objects.

"//extracted",
"attacks" : {
    "attack_text_u" : "You bite into %s with your ratlike incisors",
    "attack_text_npc" : "%1$s bites %2$s with their ratlike incisors",
},

"//failed",
"attacks" : [
    {
        "attack_text_u" : "You sink your fangs into %s",
        "attack_text_npc" : "%1$s sinks their fangs into %2$s"
    },
    {
        "attack_text_u" : "You sink your fangs into %s",
        "attack_text_npc" : "%1$s sinks their fangs into %2$s"
    }
]
Contributor

AMurkin commented Oct 10, 2017

no. 4 - extract_mutation in extract_json_strings.py counts attacks as objects, but they also can be arrays of objects.

"//extracted",
"attacks" : {
    "attack_text_u" : "You bite into %s with your ratlike incisors",
    "attack_text_npc" : "%1$s bites %2$s with their ratlike incisors",
},

"//failed",
"attacks" : [
    {
        "attack_text_u" : "You sink your fangs into %s",
        "attack_text_npc" : "%1$s sinks their fangs into %2$s"
    },
    {
        "attack_text_u" : "You sink your fangs into %s",
        "attack_text_npc" : "%1$s sinks their fangs into %2$s"
    }
]
@AMurkin

This comment has been minimized.

Show comment
Hide comment
@AMurkin

AMurkin Oct 12, 2017

Contributor

no. 1 - "reload_noise" now handled by def extract(item, infilename), but items with "type": "GUN" really handled by def extract_gun(item).

if "reload_noise" in item:
    item_reload_noise = item.get("reload_noise")
    writestr(outfile, item_reload_noise)

I think.

Contributor

AMurkin commented Oct 12, 2017

no. 1 - "reload_noise" now handled by def extract(item, infilename), but items with "type": "GUN" really handled by def extract_gun(item).

if "reload_noise" in item:
    item_reload_noise = item.get("reload_noise")
    writestr(outfile, item_reload_noise)

I think.

@Night-Pryanik

This comment has been minimized.

Show comment
Hide comment
@Night-Pryanik

Night-Pryanik Dec 16, 2017

Member

Untranslated attitude was fixed in #22623.

Member

Night-Pryanik commented Dec 16, 2017

Untranslated attitude was fixed in #22623.

@AMurkin

This comment has been minimized.

Show comment
Hide comment
@AMurkin

AMurkin Aug 26, 2018

Contributor

Suggest to test and split remaining issues.

Contributor

AMurkin commented Aug 26, 2018

Suggest to test and split remaining issues.

@Night-Pryanik

This comment has been minimized.

Show comment
Hide comment
@Night-Pryanik

Night-Pryanik Aug 27, 2018

Member

The remaining issues still exist on 0.C-7777.

Member

Night-Pryanik commented Aug 27, 2018

The remaining issues still exist on 0.C-7777.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment