Fixed weird line shifting for long (translated) strings #25168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
Info / User Interface
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Fixed weird line shifting for long (translated) strings"Purpose of change
Should fix the last issue in #22102.
Describe the solution
Long translated strings in Protection section (Bash, Cut, Acid, Fire) are auto-wrapped already, so I removed the explicit insertion of new line after the Acid.
Describe alternatives you've considered
We could leave the explicit insertion of new line after the Acid, and remove the
spacebefore it instead. But clothing and armor that have low protection values make it possible to fit all four of them in one line, that's why I didn't choose this way (it will always place the Acid on the second line no matter if protection values fit in one line).