Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alt+f4 closes cataclysm-tiles when another window has focus #23228

Closed
ymber opened this issue Mar 16, 2018 · 3 comments · Fixed by #23878
Closed

alt+f4 closes cataclysm-tiles when another window has focus #23228

ymber opened this issue Mar 16, 2018 · 3 comments · Fixed by #23878
Labels
<Bug> This needs to be fixed OS: Linux Issues related to Linux operating system (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter (S2 - Confirmed) Bug that's been confirmed to exist SDL: Tiles / Sound Tiles visual interface and sounds.

Comments

@ymber
Copy link
Member

ymber commented Mar 16, 2018

Game version:
0.C-26469-ge9970dde19

Operating system:
Arch Linux 4.15.8-1-ARCH x86_64
xfwm4

Tiles or curses:
Tiles

Mods active:
N/A

Expected behavior

Cataclysm closes when alt+f4 is pressed while it has focus.

Actual behavior

Cataclysm closes when alt+f4 is pressed while the window above it has focus.

Steps to reproduce the behavior

Give cataclysm focus.
Give a different window focus.
Press alt+f4.
Focused window and cataclysm close.
@illi-kun illi-kun added <Bug> This needs to be fixed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Mar 16, 2018
@illi-kun
Copy link
Contributor

Can't reproduce this on Windows 10 system, so maybe it's linux specific issue.

@Leland Leland added the OS: Linux Issues related to Linux operating system label Mar 25, 2018
@RustyPotato
Copy link
Contributor

RustyPotato commented Mar 27, 2018 •
edited

Confirmed on Linux. Ubuntu 16.04. Unique to tiles, doesn't apply to regular cata.

@Leland Leland added (S2 - Confirmed) Bug that's been confirmed to exist SDL: Tiles / Sound Tiles visual interface and sounds. and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Mar 27, 2018
@BevapDin
Copy link
Contributor

Most likely caused by code in "sdltiles.cpp" line 1280. It checks the current key status and if ALT and F$ are down, it quits the game. This as introduced by 99be2ad, apparently because "old sdl version doesn't support that directly". Note that this was done with SDL 1, we ow use SDL 2, so this code can probably be removed.

@ZhilkinSerg ZhilkinSerg added the (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter label Apr 2, 2018
BevapDin added a commit to BevapDin/Cataclysm-DDA that referenced this issue May 28, 2018
@BevapDin
Remove separate handling of Alt+F4 in SDL builds
688f113 
Apparently added "for older SDL lib" (whatever that means). Most likely caused the bug CleverRaven#23228.
@BevapDin BevapDin mentioned this issue May 28, 2018
Merged
kevingranade pushed a commit that referenced this issue May 30, 2018
@BevapDin @kevingranade
Remove separate handling of Alt+F4 in SDL builds (#23878)
6364f03 
Apparently added "for older SDL lib" (whatever that means). Most likely caused the bug #23228.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed OS: Linux Issues related to Linux operating system (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter (S2 - Confirmed) Bug that's been confirmed to exist SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove separate handling of Alt+F4 in SDL builds BevapDin/Cataclysm-DDA
6 participants
@Leland @BevapDin @illi-kun @ZhilkinSerg @RustyPotato @ymber