Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FEMA evacuation pamphlet "looks_like": "newest_newspaper" instead "newspaper" #35858

Closed
Lamandus opened this issue Dec 4, 2019 · 5 comments · Fixed by #35862
Closed

Comments

@Lamandus
Copy link
Contributor

Lamandus commented Dec 4, 2019

Since the FEMA pamphlet is a new object, wouldn't it be a good idea to make it look like a paper note? At least until the tilesetprocers catch up?

Edit: as @sah4001 correctly stated, it "looks like newspaper" but since "newspaper" is not an valid id, it returns "false", so to speak, and should be "newest_newspaper" instead.

@sah4001
Copy link
Contributor

sah4001 commented Dec 4, 2019

It currently looks like newspaper at the time of writing.

@Lamandus
Copy link
Contributor Author

Lamandus commented Dec 4, 2019

It currently looks like newspaper at the time of writing.

Yes it does, but there is no id named "newspaper".
So it should be either newest_newspaper or weeks_old_newspaper, or am I wrong?

so
"looks_like": "newspaper",

should actually be
"looks_like": "newest_newspaper",

@Lamandus Lamandus changed the title Make FEMA evacuation pamphlet "looks like note" Make FEMA evacuation pamphlet "looks_like": "newest_newspaper" instead "newspaper" Dec 4, 2019
@sah4001
Copy link
Contributor

sah4001 commented Dec 4, 2019

you are right, newest newspaper seems best
EDIT:
Was used to the old naming, all newspapers used to be newspaper, and i expect that is why it was named wrong

@sah4001
Copy link
Contributor

sah4001 commented Dec 4, 2019

Pull request made

@Lamandus
Copy link
Contributor Author

Lamandus commented Dec 4, 2019

Pull request made

thanks mate. Closing down!

@Lamandus Lamandus closed this as completed Dec 4, 2019
ZhilkinSerg added a commit that referenced this issue Dec 4, 2019
I-am-Erk pushed a commit to I-am-Erk/Cataclysm-DDA that referenced this issue Dec 6, 2019
Make FEMA evacuation pamphlet "looks_like": "newest_newspaper" instead "newspaper"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants