Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guns of the same make isn't stacking #36715

Closed
DillonSimeone opened this issue Jan 5, 2020 · 1 comment · Fixed by #48143
Closed

Guns of the same make isn't stacking #36715

DillonSimeone opened this issue Jan 5, 2020 · 1 comment · Fixed by #48143
Assignees
Labels
<Bug> This needs to be fixed Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@DillonSimeone
Copy link
Contributor

Describe the bug

image

In the image above, you can see that some of my guns are stacking while others isn't. Toggling debug mode then comparing two of the guns that wasn't stacking reveals that both have very tiny foulings on them.

image

Steps To Reproduce

  1. Debug in a few copies of the same gun, some magazines and a whole lot of ammo. You'll see that the guns will stack.

  2. Fire some bullets from one, then note that despite having no fouling displayed, the gun you used will not stack with other guns anymore.

Expected behavior

Guns of the same make stacking despite having little enough foulings that it doesn't display in the inventory screen, because otherwise there's nothing else telling the player that those guns are different from each other.

Screenshots

image

Having so many same guns not stacking makes it difficult to look though your piles of guns.

Versions and configuration

  • OS: Windows 10
  • Game Version: O.D-11016-g91d7b51
  • Graphics version: Tiles
  • Mods loaded:
    "dda",
    "no_npc_food",
    "magiclysm",
    "aftershock",
    "crt_expansion",
    "FIC_Weapons",
    "growable-pots",
    "ew_pack",
    "makeshift",
    "Medieval_Stuff",
    "More_Survival_Tools",
    "nw_pack",
    "alt_map_key",
    "Cata++",
    "Mining_Mod",
    "my_sweet_cataclysm",
    "MMA",
    "vamp_stuff",
    "Arcana",
    "vamp_stuff+arcana",
    "more_locations",
    "No_Rail_Stations",
    "deoxymod",
    "blazemod",
    "Heavy miners",
    "Tanks",
    "necromancy",
    "Arts' Guns",
    "no_religious_Texts",
    "novitamins",
    "speedydex",
    "secronom",
    "stats_through_kills"

Other

I've attached my savefile to this issue so you can quickly examine the guns. In the save, I have a bunch of guns sitting in my inventory, and there's even more guns south of the worktable in my car.

Forest Hills.zip

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 5, 2020
@wapcaplet
Copy link
Contributor

Confirmed, and still an issue in 0.E-10095-g9a1187f549. Every foulable gun keeps an exact count of the number of bullets it has fired, and no guns will stack unless they have fired exactly the same number of bullets.

Here are 5 Glock 17 handguns that have each fired a different number of bullets between 0 and 5, on the ground:

image

And in the inventory:

image

With debug mode turned on, one can see the "dirt" value that causes them not to stack:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants