Weekly Digest (5 January, 2020 - 12 January, 2020) #36987

weekly-digest · 2020-01-12T23:00:24Z

Here's the Weekly Digest for CleverRaven/Cataclysm-DDA:

ISSUES

Last week 233 issues were created.
Of these, 151 issues have been closed and 82 issues are still open.

OPEN ISSUES

💚 #36941 Fix melee_damage entry in MONSTER.md doc, by Fris0uman
💚 #36939 Bittersweet encounters, by Fris0uman
💚 #36938 Foraging Multiplication, by Grubleafeater
💚 #36937 Magiclysm - JSONize spellcasting skill, by foulman
💚 #36936 Some random NPCs spawn without appearance traits, by Zaragata
💚 #36934 Auto-Chop in designated Area with a hachet results in error, by kuhnchris
💚 #36932 Crafting Recipe Error with salt_water / water_clean on Game Load, by Chronakai
💚 #36931 Rework gunsafe contents., by Brian-Otten
💚 #36924 Show current weight (and limit) and Volume (and its limit) in the UI (as togglable option), by Lamandus
💚 #36923 Add more info to overmap terrain editor debug menu, by ZhilkinSerg
💚 #36920 Remove modularvest items, by ymber
💚 #36919 Move ammo effects to JSON, by ymber
💚 #36917 Fix slow vehicle processing., by kevingranade
💚 #36916 Game crash on finishing/accepting next ranch mission, by dongboka
💚 #36911 Re-Wrap recipes (Second Pass), by Soup-de-Loop
💚 #36909 Blindness should probably debuff dodge and tohit., by Brian-Otten
💚 #36908 WIP [Aftershock] Millyficent whately and the migo , by Maleclypse
💚 #36904 Can gain infinite trust and negative infinite anger for any npc, by CoroNaut
💚 #36901 Dragon skin should be replaced, by Brian-Otten
💚 #36900 Deprecate terrible "chance" and "prob" JSON attributes, by I-am-Erk
💚 #36894 (2) crashes during game saves in recent play., by 1FSTCAT
💚 #36890 Expand variety of NBC suits., by Brian-Otten
💚 #36884 "Consume item" window is reset if a filter was set, by Ulysses2
💚 #36883 Some inactive bots can't be disassembled, by Ulysses2
💚 #36881 Reactor Core Expansion Device and the Minireactor, by Jakalor
💚 #36877 Move surgery related functions to Character, by Fris0uman
💚 #36874 Guns with attached shoulder strap can drop with "filthy" tag, by GGgatherer
💚 #36872 upgrade reversible recipe property, by 1n17
💚 #36870 Added "Trap Back button" option to Android prelaunch menu, by ZhilkinSerg
💚 #36862 increase kcal spent walking with carry weight, by KorGgenT
💚 #36860 Add a vibrator crafting recipe, by wapcaplet
💚 #36859 Provide ability to execute an action from the keybindings menu, by scrotty
💚 #36858 Inconsistent glass weight values, by Soup-de-Loop
💚 #36853 Military armor balance, by Brian-Otten
💚 #36852 Rework MonsterGenerator into generic_factory, by KorGgenT
💚 #36851 Rework Item_factory to use generic_factory, by KorGgenT
💚 #36850 Monster mutations, by I-am-Erk
💚 #36847 Added 9 NPCs, misc improvements, by LovamKicsiGazsii
💚 #36844 Some foodstuffs don't have vitamins at all, by AntMatriarch
💚 #36841 Taking stuff apart, by 1n17
💚 #36839 [WIP] Generic Guns rework, by tenmillimaster
💚 #36838 Add FS2000(plus STANAG mag volume update), by LaVeyanFiend
💚 #36835 Add a way to automatically heal the character with available consumables., by Brian-Otten
💚 #36834 Change all dialogue to prose (mini project), by I-am-Erk
💚 #36833 Going up stairs from a basement teleport to different set of stairs., by UndeadMoose
💚 #36832 "Dormant" monster attribute., by I-am-Erk
💚 #36831 40mm Pipe Launcher has zero range (Cannot fire), by Demator027
💚 #36826 Cows do not produce milk outside reality bubble, by Demator027
💚 #36824 Segfault upon loading a save, by killwort
💚 #36820 Deceased monsters don't count as such until some action is taken, by GGgatherer
💚 #36816 Increased default overmap search radius, by Ker-Nes
💚 #36814 Webbing belt does nothing, by Kelenius
💚 #36808 Signed integer overflow in JsonIn::get_int, by hexagonrecursion
💚 #36804 Add option to change position of look around windows, by Kilvoctu
💚 #36802 change scope of some player member functions, by KorGgenT
💚 #36792 Let me mark obstacles for the overmap auto walk feature, by Inglonias
💚 #36790 book_learn optional third entry does nothing?, by Jerimee
💚 #36789 New map search function that can feasibly search the entire map, by Ker-Nes
💚 #36788 Makeshift Earplugs, by chaoticidealism
💚 #36786 Add new safemode rule category for ignoring sounds, by Ramza13
💚 #36784 Libraries in science labs are woefully understocked, by Inglonias
💚 #36783 Vanishing wreckage, by Alterforce
💚 #36776 Damaged doors don't react to movement/open, causes inconsistency., by WeaverThree
💚 #36770 added batch time saving of 80% from 2 units for all nuts based recipes, by 8ctopus
💚 #36765 Big balance breaking bug: Train dodge using boomers up to the 11th level, by Aphegis
💚 #36761 Repairing uncraftable armor/clothes is currently too hard, by Brian-Otten
💚 #36759 Rebalancing armors, by Ker-Nes
💚 #36758 Drinking hat with liquid wears off after crafting, by Foxtrot-Uniform42
💚 #36757 Foldable turret mount becomes unfoldable with gun attached, by Shodan14
💚 #36754 Cold Pressing Oil from Seeds through the power of Wind, by Ker-Nes
💚 #36747 Canning apple cider and other juices, by Maleclypse
💚 #36744 CBM idea: Implanted Radio, by cozardi
💚 #36742 Weapon Duplication , by TaxVEVO
💚 #36739 False "Does not fit" tag on Survivor Goggles, by DocGhast
💚 #36733 Add demon chitin armor, by LaVeyanFiend
💚 #36731 Laser Weapons can Spawn with gunpowder fouling, by Ker-Nes
💚 #36730 Refactor encumbrance, by ymber
💚 #36726 Unloading guns does not warn of approaching enemies, by Grubleafeater
💚 #36722 Refactor monsters shift-v menu, by 8street
💚 #36721 Leaky turrets. Bullets falling out., by TechyBen
💚 #36716 Firing mode toggle on firearms keeping them from stacking, by DillonSimeone
💚 #36715 Guns of the same make isn't stacking, by DillonSimeone

CLOSED ISSUES

LIKED ISSUE

👍 #36732 Adds military helipad location, by CountAlex
It received 👍 x10, 😄 x0, 🎉 x0 and ❤️ x2.

NOISY ISSUE

🔈 #36759 Rebalancing armors, by Ker-Nes
It received 21 comments.

PULL REQUESTS

Last week, 141 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 1 pull request was opened.
💚 #36923 Add more info to overmap terrain editor debug menu, by ZhilkinSerg

UPDATED PULL REQUEST

Last week, 25 pull requests were updated.
💛 #36911 Re-Wrap recipes (Second Pass), by Soup-de-Loop
💛 #36872 upgrade reversible recipe property, by 1n17
💛 #36870 Added "Trap Back button" option to Android prelaunch menu, by ZhilkinSerg
💛 #36860 Add a vibrator crafting recipe, by wapcaplet
💛 #36859 Provide ability to execute an action from the keybindings menu, by scrotty
💛 #36847 Added 9 NPCs, misc improvements, by LovamKicsiGazsii
💛 #36802 change scope of some player member functions, by KorGgenT
💛 #36747 Canning apple cider and other juices, by Maleclypse
💛 #36733 Add demon chitin armor, by LaVeyanFiend
💛 #36722 Refactor monsters shift-v menu, by 8street
💛 #36703 Metal bridge over air tiles, by RafeHaab
💛 #36672 Magiclysm: Forest Tomb, by arijust
💛 #36663 Extended shift-v items menu, by 8street
💛 #36650 Removed everything with CUT quality of 2., by Kelenius
💛 #36611 Removing legacy json name / name_plural convention., by jayhide
💛 #36543 Auto eat and drink from auto-zones during long activities/waiting, by davidpwbrown
💛 #36089 Reworked how crafting skill requirement display is generated., by ishtatann
💛 #36074 Add "forbidden traits" to professions , by np-vortex
💛 #35545 Add stub code for applying migrations to downstream item lists., by kevingranade
💛 #35540 [WIP]Framework for out-of-reality-bubble NPC activities 1:foraging, by davidpwbrown
💛 #35522 [WIP]Aramid armor is like an onion, it has many layers: Kevlar rework, EOD gear and cut-gear., by tenmillimaster
💛 #35371 Add "looks_like" to all furniture and terrain, by XygenSS
💛 #34690 Towing vehicles, by davidpwbrown
💛 #34246 [WIP]NPC and player auto-crafting from workbench bills, by davidpwbrown
💛 #33829 Flyable Helicopters, by davidpwbrown

MERGED PULL REQUEST

COMMITS

Last week there were 186 commits.
🛠️ [update 5 additional houses (#36933) * udpate 5 additional houses

fix garage8](c8cc213) by curstwist
🛠️ magiclysm - fix hand impeding spell costs by KorGgenT
🛠️ Adding ru translation notes (#36868) by 8street
🛠️ Merge pull request #36935 from kuhnchris/patch-1 [minor] Aikido's description typo by ZhilkinSerg
🛠️ Merge pull request #36905 from KorGgenT/orichalcum-bike [magiclysm] orichalcum bike by ZhilkinSerg
🛠️ Merge pull request #36918 from LilShiningMan/LSM---food.json-correction food.json - duplicates removed by ZhilkinSerg
🛠️ Merge pull request #36929 from Qrox/toxic-oil Fix cooking oil made from mutant fat not containing toxin by ZhilkinSerg
🛠️ retroplus sync update (#36921) by captnblood
🛠️ Merge pull request #36927 from jbytheway/rename_test_files Rename test files for consistency by ZhilkinSerg
🛠️ Merge pull request #36926 from BevapDin/uos Properly initialize members of options_manager::cOpt by ZhilkinSerg
🛠️ Aikido's description typo Said "tehcnique" instead of "technique" by kuhnchris
🛠️ Disable nutrient override for animal cooking oil by Qrox
🛠️ Add clang-tidy check for test filenames Enforce the rule that test files should be named *_test.cpp. by jbytheway
🛠️ Rename test files for consistency Have all files containing tests be named *_test.cpp. by jbytheway
🛠️ Properly initialize members of options_manager::cOpt Specifically initialize members that get used when serializing the option value (which triggers printing the default value, so we need a valid one). by BevapDin
🛠️ More warmth for heavy survivor helmet by Brian-Otten
🛠️ Helmet adjustment Army helmet now closer to its real world protection. Heavy survivor helmet is now a modified army helmet for 100% coverage but more weight. Heavy survivor helmet protective stats unchanged by Brian-Otten
🛠️ Update tool_qualities.json by undefined
🛠️ angular by undefined
🛠️ Update monstergroups.json by RarkGrames
🛠️ Merge pull request #36857 from Brian-Otten/Riot-armor-buff Mild riot armor buff by Rivet-the-Zombie
🛠️ food.json - duplicates removed removed duplicate item group entries in food.json by LilShiningMan
🛠️ Merge pull request #36910 from curstwist/house-update-8 update 3 more houses by ZhilkinSerg
🛠️ Merge pull request #36915 from anothersimulacrum/retrodays RetroDays tileset update by ZhilkinSerg
🛠️ Merge pull request #36907 from CleverRaven/kevingranade-feathub-widget Add a feathub widget by ZhilkinSerg
🛠️ remove plastic golem death drops (#36912) by KorGgenT
🛠️ RetroDays update by anothersimulacrum
🛠️ 3 more houses by curstwist
🛠️ Francis X. Clampazzo by undefined
🛠️ Add a feathub widget by kevingranade
🛠️ [magiclysm] orichalcum bike by KorGgenT
🛠️ [Makes AEP and ANBC suit harder to craft. (Makes AEP and ANBC suit harder to craft. #36887) * Makes AEP and ANBC suit harder to craft.

AEP and ANBC suit took very low levels of tailoring to make (1 and 2). the tailoring level required is now 1 lower than the fabrication required. ANBC now takes appropiate amounts of kevlar to make.](64b5e04) by Brian-Otten
🛠️ Changes to gravel deconstruct recipe. (#36888) by arijust
🛠️ Fix deserialization of submap radiation: (#36903) Check bounds before setting the value. by BevapDin
🛠️ Merge pull request #36889 from Qrox/auto-sort-veh Stop auto sort from visiting empty vehicle tiles by ZhilkinSerg
🛠️ Merge pull request #36897 from Qrox/remote-veh-speed Fix vehicle speed overlaps player speed when using remote vehicle controls by ZhilkinSerg
🛠️ Fix missing overmap legend (#36879) by 8street
🛠️ [Fix AT4 launcher. (#36886) * Tweak AT4

Modify guns_launcher_rocket itemgroup.](37cfe25) by arijust
🛠️ Merge pull request #36876 from hexagonrecursion/patch-4 Fix floating point divide by zero in game::update_overmap_seen by ZhilkinSerg
🛠️ Merge pull request #36882 from Qrox/help-dir Fix unreplaced tag in the help UI when there's less than two bound keys for a movement action by ZhilkinSerg
🛠️ Merge pull request #36895 from Qrox/magic-basement-error Fix debug message when loading magic_basement from save by ZhilkinSerg
🛠️ [First two wizard towers for Magiclysm (First two wizard towers for Magiclysm #36588) * create a cool tower
create a cool tower
lint
split it up into a few files
move golems to their own file
wizard tower 2 - still needs some tweaking
landscaping
lint constructs.json
Update regional_overlay.json
lint wizard towers
Apply suggestions from code review

Co-Authored-By: Curtis Merrill curtis.r.merrill@gmail.com

Update overmap_terrain.json
Update regional_overlay.json
Update wizard-towers.json
Update wizard-towers.json
Update wizard-towers.json

Co-authored-by: Curtis Merrill curtis.r.merrill@gmail.com](8ad5459) by I-am-Erk
🛠️ Clear traps in monster tests (#36865) Per https://github.com/CleverRaven/Cataclysm-DDA/pull/36664#issuecomment-572362817 by ZhilkinSerg
🛠️ Routine i18n updates on 10 Jan 2020 by BrettDong
🛠️ [Fix signed integer overflow in pixel_minimap::prepare_cache_for_updates (#36873) * Fixes #36807

Assumptions:

cached_center_sm is only used in prepare_cache_for_updates
The first time prepare_cache_for_updates is called cache is empty, which means both branches of if are no-op and it does not matter which one it executed.

Remove redundant initialization

Apparently tripoint is zero-initialized by default. Thanks travis-ci for running clang-tidy.](4d2187e) by hexagonrecursion
🛠️ Fixes #36813 (#36880) by hexagonrecursion
🛠️ [Bookplate buff (#36867) * Change bookplate

Bookplate now requires more paper, is heavier and more encumbering, but gives some meaningful protection.

Makes bookplate take more paper to craft

Since the armor is heavier it now needs more paper.](88e6cff) by Brian-Otten
🛠️ Update recovery effect for 1s turn (#36892) by Fris0uman
🛠️ Only list tilesets once (#36896) by Fris0uman
🛠️ Obsolete royal jelly recipe (#36902) by Fris0uman
🛠️ fix find and replace error (#36898) by I-am-Erk
🛠️ Fix vehicle speed overlaps player speed when using remote vehicle controls by Qrox
🛠️ Fix debug message when loading magic_basement from save by Qrox
🛠️ Stop auto sort from visiting empty vehicle tiles by Qrox
🛠️ Display unbound key as a red ? instead of an unreplaced tag in the help UI by Qrox
🛠️ Fixes #36809 by hexagonrecursion
🛠️ ID change by undefined
🛠️ Onboard chemistry lab electrolysis (#36822) by 1n17
🛠️ Merge pull request #36657 from jbytheway/duplicate_components Correctly predict craftability of recipes with overlapping item requirements by kevingranade
🛠️ [(done) House basements 1 (house04, 05, 06, 07, quiverfull, and library) (#36707) * Start adding basement 04

fill basement room with more chunks
house04 basement
expand coverage of new basements
complete the basement additions on all the 22x22 maps
remove no_rotate from basement

I'm not sure why it would be there in the first place

Add _north suffix now that basements can rotate
Update overmap_terrain_residential.json
tweak rotation settings for procgen terrain
adjustments to reduce monster spawn rate
lint](57ca262) by I-am-Erk
🛠️ Merge pull request #36849 from Fris0uman/emprojector EMP projector default firing mode is semi-auto instead of auto by ZhilkinSerg
🛠️ [TOW Humvee variant (TOW Humvee variant #36794) * Added vehicle
Added vehicle to groups
Update tests](615e213) by RarkGrames
🛠️ Merge pull request #36760 from CleverRaven/kevingranade-charged-batteries-for-debug Wished for items span with full charges or ammunition by ZhilkinSerg
🛠️ Debug Bionic Installation allows fast operation (#36812) by Fris0uman
🛠️ [Fix Nurse bot Checkup (Fix Nurse bot Checkup #36810) * Clearer message and longer countdown
Shorter CHECK_UP cooldown
Update defective nurse bot speech](a12d982) by Fris0uman
🛠️ Merge pull request #36800 from John-Candlebury/hologram Improved hologram behavior by ZhilkinSerg
🛠️ Merge pull request #36863 from Brian-Otten/removespawn-improvisedfilledmbr Remove improvised filled MBR from military spawngroups by ZhilkinSerg
🛠️ [Fix various bugs with auto move (Fix various bugs with auto move #36712) * Fix bugs on finishing auto move

When auto moving in iso mode, the player takes the wrong step for the last point in the auto move route, causing the activity at the destination (such as auto sort) to be canceled
When auto moving with a monster/npc on the final tile, the player automatically attacks the monster/talks to the npc when reaching that tile
When the last auto move tile is a fence gate/vehicle door etc, auto move stops without starting the activity at the destination

Make ACTION_MOVE_XXX always represent the actioin input rather than the executed action
Fix toggleable auto travel mode
Rename ACTION_MOVE_ actions to better reflect their meaning
Move one tile at a time in toggleable auto travel](1ce9b9e) by ZhilkinSerg
🛠️ Replace my_bionics with get_bionics() where possible and various code cleaning (#36846) by Fris0uman
🛠️ Merge pull request #36854 from Jerimee/patch-10 m Update JSON_INFO.md by ZhilkinSerg
🛠️ [Add four new cookbooks (Add four new cookbooks #36793) * adds 4 new cookbooks to cooking.json

SUMMARY: Content "Add four new cookbooks"

Update cooking.json
Update recipe_food.json
Update recipe_food.json
Update recipe_food.json
Update offal_dishes.json
Update offal_dishes.json
Update offal_dishes.json
Update mansion.json
Update data/json/items/book/cooking.json

Co-Authored-By: matskuman5 selinmatias5@gmail.com

Update data/json/recipes/food/offal_dishes.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/recipes/food/offal_dishes.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/recipes/recipe_food.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/recipes/recipe_food.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/recipes/recipe_food.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update recipe_food.json
Update offal_dishes.json
Update data/json/recipes/recipe_food.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/items/book/cooking.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update recipe_food.json

Co-authored-by: matskuman5 selinmatias5@gmail.com
Co-authored-by: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com](0d7ed15) by Jerimee
🛠️ Merge pull request #36855 from Brian-Otten/Fire-extinguisher-volume-fix Updates fire extinguisher volumes to match container volumes by Rivet-the-Zombie
🛠️ Merge pull request #36576 from KorGgenT/fix-time-travel-due-to-1s-turns fix time travel due to 1s turns by kevingranade
🛠️ Genericized hand vise, corrected britishisms by undefined
🛠️ Remove improvised filled MBR from military spawngroups Military no longer has MBR filled with improvised steel/superalloy/hardsteel plates. Other MBR spawnrate increased to keep total amount of spawning MBR constant. Improvised MBR is still in the survivor spawn groups. by Brian-Otten
🛠️ Stop unnecessary visited member logging outside of unit test (#36805) by Qrox
🛠️ Mild riot armor buff Riot armor now covers legs, has 85% coverage, and very slightly more material thickness (soaks). by Brian-Otten
🛠️ [Update military surplus stores (#36825) * Split infantry clothing and combat gear groups

Update military surplus stores
Fix spawn chances](bd3a2e3) by ymber
🛠️ Updates fire extinguisher volumes to match container volumes Als slightly increases weight and charges of the large extinguisher to match new volume. by Brian-Otten
🛠️ Update JSON_INFO.md by Jerimee
🛠️ Clarify cbm_slots mod description (#36848) by anothersimulacrum
🛠️ Add disassemble recipe for 1cyl_combustion_large (#36843) by arijust
🛠️ EMP projector default firing mode is semi-auto instead of auto by Fris0uman
🛠️ Add NO_RELOAD flag to LAW. (#36845) by arijust
🛠️ Move one tile at a time in toggleable auto travel by Qrox
🛠️ Rename ACTION_MOVE_ actions to better reflect their meaning by Qrox
🛠️ Fix toggleable auto travel mode by Qrox
🛠️ Make ACTION_MOVE_XXX always represent the actioin input rather than the executed action by Qrox
🛠️ Fix bugs on finishing auto move - When auto moving in iso mode, the player takes the wrong step for the last point in the auto move route, causing the activity at the destination (such as auto sort) to be canceled - When auto moving with a monster/npc on the final tile, the player automatically attacks the monster/talks to the npc when reaching that tile - When the last auto move tile is a fence gate/vehicle door etc, auto move stops without starting the activity at the destination by Qrox
🛠️ Merge pull request #36840 from park66665/fixitxenomedes Stop power armors and FB51 optical cloak from eating peoples energy while being inactive by Rivet-the-Zombie
🛠️ Duct-tape if w.active by park66665
🛠️ update 2 houses (#36836) by curstwist
🛠️ Remove obsolete or excessively meta tips (#36828) by kevingranade
🛠️ Update JSON_INFO.md (#36827) by Jerimee
🛠️ Update s_clothes chances (#36823) by ymber
🛠️ [Allow armor inserts in ballistic vests (Allow armor inserts in ballistic vests #36778) * Allow armor inserts in ballistic vests
Reduce assembly time
Update ballistic plate descriptions](e7fabca) by ymber
🛠️ [Construction recipe for barred window with curtains (Construction recipe for barred window with curtains #36797) * Construction recipe for barred window with curtains
lint
add conditional for tear down

Add conditional handler for tearing down curtains from a barred window

fix missing declaration

No shortcuts... download a compiler, learn c++, and finish what I started.
Game compiles, load save, no error, tear down curtain and they stayed down

astyle

learn what astyle is and attempt application. minor fix, remove unneeded "."'s](0e87154) by Kilvoctu
🛠️ Update game.cpp (#36787) remove superfluous refresh calls from list item/monster views
set item list width to match default/minimal monster list width by 1n17
🛠️ Merge pull request #36768 from John-Candlebury/holo-fighter Aftershock Corporate Infiltrator by ZhilkinSerg
🛠️ [Aftershock] Wraitheon exec helicopter crash (#36766) by Maleclypse
🛠️ Merge pull request #36801 from John-Candlebury/afs-butcher-fix [Aftershock] Fix butchery results by ZhilkinSerg
🛠️ Merge pull request #36803 from jbytheway/no_unknown_warning Use -Wno-unknown-warning to simplify warnings selection by ZhilkinSerg
🛠️ [Increase assisted effect from nurse bot (#36798) * Increase max_intensity of assisted effect

Increase intensity of assisted effect from nurse bot](a74605a) by Fris0uman
🛠️ Fix redraw in vehicle interaction menu by ZhilkinSerg
🛠️ Create wished for items with maximum charge or ammunition. by kevingranade
🛠️ Revert "Lower material thickness for ballistic vest." by kevingranade
🛠️ Merge pull request #36799 from arijust/ballistic_vest Lower material thickness for ballistic vest. by Rivet-the-Zombie
🛠️ various little changes in retrodays+ (#36780) by captnblood
🛠️ Use -Wno-unknown-warning to simplify warnings A gcc-specific warning option had been added (-Wsuggest-override). In theory this was guarded against being used with clang, but that didn't work if a compilation database was built with gcc and then used with e.g. clang-tidy. In that situation clang would complain about the unrecognized warning. The suggested workaround in the DEVELOPER_TOOLING docs was to add -Wno-unknown-warning-option, a clang option to suppress such warnings. However, we might as well just add that option always, then we don't need to make the -Wsuggest-override conditional and the build logic is simplified. Technically, gcc has no such option, but gcc doesn't complain about unrecognized disabled warning options (unless there's another error) so we get lucky there. Hopefully that remains true back to our earliest supported gcc. This might cause problems for compiling with another compiler e.g. icc, but the way the Makefile was written, it would have had that problem anyway, since it was added for any non-clang compiler. by jbytheway
🛠️ [Adds military helipad location (Adds military helipad location #36732) * Adds military helipad location
JSON fixes.
Moster placing fix.
Terrain id fix.
Replace mech lifter with a forklift.
Review changes
Set of small fixes - spawns etc.
Reduce number of perimeter turrets to 4.](89ef868) by CountAlex
🛠️ Fix butchery results by John-Candlebury
🛠️ [Boxpack (Boxpack #36746) * add box backpack and recipe
add NO_REPAIR flag
edit description and recipe
Update data/json/recipes/armor/storage.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/recipes/armor/storage.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/recipes/armor/storage.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

remove stray bracket

Co-authored-by: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com](29351f0) by k4gi
🛠️ Improved hologram behavior by John-Candlebury
🛠️ Lower material thickness for ballistic vest. by arijust
🛠️ [Electrochemical reactions (#36785) * Update recipe_medsandchemicals.json

abstracting using chloralkali process (hot solution, unpartitioned cell) to produce sodium chlorate, then perchlorate by anodic oxidation on platinum, then ammonia perchlorate by double decomposition from sodium perchlorate and ammonium chloride; while we can't directly use bleach here but we do end up recovering some brine

Update recipe_medsandchemicals.json
Update recipe_medsandchemicals.json
Update recipe_medsandchemicals.json
Update recipe_medsandchemicals.json
Update recipe_medsandchemicals.json

Reevaluating skill requirements](bcff7ae) by 1n17
🛠️ [Set debug mutation as such in Magiclysm (#36774) * Set debug mutation as such in Magiclysm

Apply suggestions from code review

Co-Authored-By: anothersimulacrum anothersimulacrum@gmail.com

Co-authored-by: anothersimulacrum anothersimulacrum@gmail.com](c4c7b91) by ZhilkinSerg
🛠️ [Martial Arts missing Learn Diffculty and Incorrect Bonuses (#36772) * Martial Arts missing Learn Diffculty and Incorrect Bonuses

Medieval Swordsmanship and Leopard Stance were missing the learn difficulty, making them potentially easier to learn than intended.

Leopard stance's on move buff gave a flat bonus to damage instead of the intended multiplier.

Eskrima stance was giving a 200% bonus to accuracy instead of the intended +2 accuracy.

Added missing primary_skills

Move dbghelp symbol initialization to debug_write_backtrace
Use libbacktrace on cross-compilation to Windows
Download prebuilt libbacktrace before building
Use square brackets instead of angle brackets
Add license text of libbacktrace](764aa9f) by Qrox
🛠️ Merge pull request #36755 from anothersimulacrum/docs Add documentation for repairs_like by ZhilkinSerg
🛠️ Merge pull request #36753 from Inglonias/war-on-christmas Take down the Christmas decorations by ZhilkinSerg
🛠️ Merge pull request #36750 from Qrox/fix-typo Fix a typo in avatar.cpp by ZhilkinSerg
🛠️ Add documentation for repairs_like by anothersimulacrum
🛠️ Take down the Christmas decorations by Inglonias
🛠️ Merge pull request #1 from Ker-Nes/Ker-Nes-grapes Adding Grape Seeds to the cooking oil recipe by Ker-Nes
🛠️ Adding Grape Seeds to the cooking oil recipe Grape seed oil: https://en.wikipedia.org/wiki/Grape_seed_oil by Ker-Nes
🛠️ [Magiclysm: Holographic transposition spell (Magiclysm: Holographic transposition spell #36714) * Holographic transposition spell
Add spawn for the holographic transposition scroll
Remove outdated flag
Remove unused function parameter
Changes suggested by code review.
Update data/mods/Magiclysm/items/spell_scrolls.json

Co-Authored-By: Jianxiang Wang (王健翔) qrox@sina.com

Fix misplaced coma in spell_scrolls.json
Apply suggestions from code review

Co-Authored-By: LaVeyanFiend 51099123+LaVeyanFiend@users.noreply.github.com

Co-authored-by: Jianxiang Wang (王健翔) qrox@sina.com
Co-authored-by: LaVeyanFiend 51099123+LaVeyanFiend@users.noreply.github.com](8ad1db2) by John-Candlebury
🛠️ update next 5 houses (#36741) by curstwist
🛠️ Fix typo by Qrox
🛠️ Merge pull request #36736 from kevingranade/fix-ant-tunnels Fixes to ant lair generation by Rivet-the-Zombie
🛠️ Fixes to ant lair generation by kevingranade
🛠️ Merge pull request #36724 from ZhilkinSerg/sa-2020-01-05 Code optimizations reported by static code analysis (2020-01-05) by kevingranade
🛠️ [Mr Lapin NPC Warrener (#36287) * Classes and NC Rabbit Raiser

Mr Lapin and edits to class items
Cabin additions

Mission change in npc as well

Linting

and validation

Update Mr_Lapin.json
try to fix errors
remove chance

Maybe this will work?

Update cabin.json
I think this has fixed it
Update classes.json
item groups and collections
Update NC_Rabbit_Raiser.json

learning new ways to mark entries

Update classes.json
See if this works
fixed errors from tests
Update specials.json
Update specials.json
Update overmap_terrain.json
Update Mr_Lapin.json
Update Mr_Lapin.json
Update Mr_Lapin.json
Additional spaces after punctuation
Update data/json/overmap/overmap_special/specials.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Move class to Lapin file

Consolidating to the holdouts npc file.

Co-authored-by: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com](f069282) by Maleclypse
🛠️ retrodays+ updates (#36735) by captnblood
🛠️ Fix undefined charges-max handling (#36723) by ymber
🛠️ Move armor functions to Character (#36711) Part of the project to deprecate player by anothersimulacrum
🛠️ Freeze burn does not cause insta-rot (#36644) by 1n17
🛠️ Minor fixes to godco content. by kevingranade
🛠️ Mark royal jelly recipe secret. by kevingranade
🛠️ [Added 2 new NPCs. (#35238) * Added 2 new NPCs, upgraded mapgen

Increase food spawns
Create foodguard.json
Create cook.json
grammar fix
grammar and wording fix
grammar and wording
Update data/json/npcs/godco/cook.json

Co-Authored-By: Anton Burmistrov Night_Pryanik@mail.ru

fix novels

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

more natural speech
prob & count
fix: { "trust": 2 }

Co-authored-by: Anton Burmistrov Night_Pryanik@mail.ru
Co-authored-by: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com](bce06b8) by LovamKicsiGazsii
🛠️ [make fibrous stalk burnable (#36717) Plant derived materials do burn IRL.

references #30111](a511881) by 8ctopus
🛠️ Create canned.json (#36718) Moved canning pot and can sealer required recipes to canned.json. Leave pickled items in food.json. by Maleclypse
🛠️ update 5 more houses (#36727) by curstwist
🛠️ [Spell-casting NPCs (#35597) * spellcasting npcs

adds spellcasting npcs to magiclysm

linted

linted

continuing spellcasting npcs

should be the last peices to get them working in game

linted, again

misplaced file and linted

linted

finally, maybe.

names

more descriptive information in the mission dialog

spaces

added spaces after periods (double space after each .)

ellipses

changed ellipses to the unicode character

Update data/mods/Magiclysm/npc/missiondef.json

Co-Authored-By: Anton Burmistrov Night_Pryanik@mail.ru

Update data/mods/Magiclysm/npc/missiondef.json

Co-Authored-By: Anton Burmistrov Night_Pryanik@mail.ru

Update data/mods/Magiclysm/npc/missiondef.json

Co-Authored-By: Anton Burmistrov Night_Pryanik@mail.ru

Update data/mods/Magiclysm/npc/missiondef.json

Co-Authored-By: Anton Burmistrov Night_Pryanik@mail.ru

travis fix

fixed double space, tag in wrong file, tag incomplete

more travis
travis

maybe this is right?

travis the third
travis the final?

Co-authored-by: Anton Burmistrov Night_Pryanik@mail.ru](7a023e4) by araneyl
🛠️ Put comments to separate lines by ZhilkinSerg
🛠️ Removed redundant empty statement by ZhilkinSerg
🛠️ Normalized TODO/HACK/FIXME comments by ZhilkinSerg
🛠️ Remove excessive empty lines by ZhilkinSerg
🛠️ Remove excessive incements by ZhilkinSerg
🛠️ Remove unused declarators by ZhilkinSerg
🛠️ Merge pull request #36713 from anothersimulacrum/mv-bronze Move bronze to materials.json by ZhilkinSerg
🛠️ update houses 16-19 (#36709) by curstwist
🛠️ Merge pull request #36699 from CleverRaven/kevingranade-fix-learned-recipe-display Prune secret recipes from character creation display by Rivet-the-Zombie
🛠️ Move bronze to materials.json by anothersimulacrum
🛠️ check emptiness (#36705) by davidpwbrown
🛠️ [Prevent counterattacking with large/fragile items (#36704) Attempting to attack with very large items could lead to move
starvation, where the player would spend several turns doing nothing but
attacking.
Additionally, attacking with large items made of glass could break your
arms because the damage from breaking glass items is due to volume.

Prevent counter-attacking with items made of glass, because this can
break them, where the player may not want this to occur.

Prevent attacking with items than take more than 10 turns to attack
with, to prevent the move starvation bug.](552ecbb) by anothersimulacrum
🛠️ [Stop ant tunnels stomping over other map terrain underground and removing staircases (#36702) * stop ant tunnels stomping over other map terrain underground

also add check to adjacent loop](ada2433) by davidpwbrown
🛠️ Add "repairs_like" for items without a recipe (#36700) When items did not have a recipe, the difficulty for repairing them was
set to 10. For some items, such as scarves, this made repairing the
activated versions of them much more difficult than repairing the
non-activated versions. Now, they can have a 'repairs_like' specified,
and if they do not have a recipe, they will use the recipe of that item
instead. by anothersimulacrum
🛠️ Monster reorganize add fungus json (#36684) by Maleclypse
🛠️ Cap fire age to prevent android overflow (#36676) by davidpwbrown
🛠️ Add reload wielded keybinding (#36658) by Ramza13

CONTRIBUTORS

Last week there were 39 contributors.
👤 curstwist
👤 KorGgenT
👤 8street
👤 ZhilkinSerg
👤 captnblood
👤 kuhnchris
👤 Qrox
👤 jbytheway
👤 BevapDin
👤 Brian-Otten
👤 undefined
👤 RarkGrames
👤 Rivet-the-Zombie
👤 LilShiningMan
👤 anothersimulacrum
👤 kevingranade
👤 arijust
👤 I-am-Erk
👤 BrettDong
👤 hexagonrecursion
👤 Fris0uman
👤 1n17
👤 Jerimee
👤 ymber
👤 park66665
👤 Kilvoctu
👤 Maleclypse
👤 CountAlex
👤 John-Candlebury
👤 k4gi
👤 Xanmyral
👤 davidpwbrown
👤 Night-Pryanik
👤 Inglonias
👤 Ker-Nes
👤 LovamKicsiGazsii
👤 8ctopus
👤 araneyl
👤 Ramza13

STARGAZERS

Last week there were 18 stagazers.
⭐ HunorP
⭐ randomtyper
⭐ oslvbo
⭐ hoshino111
⭐ kWeb24
⭐ comdv
⭐ cassaundra
⭐ zhigang26
⭐ almogor
⭐ BlakeCTucker
⭐ catern
⭐ tom-james-watson
⭐ korick
⭐ CalJacobson
⭐ Feralwish
⭐ Yutyo
⭐ youngtrashbag
⭐ KOLANICH
You all are the stars! 🌟

RELEASES

That's all for last week, please 👀 Watch and ⭐ Star the repository CleverRaven/Cataclysm-DDA to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

weekly-digest bot added the weekly-digest label Jan 12, 2020

kevingranade closed this as completed Jan 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (5 January, 2020 - 12 January, 2020) #36987

Weekly Digest (5 January, 2020 - 12 January, 2020) #36987

weekly-digest bot commented Jan 12, 2020

Weekly Digest (5 January, 2020 - 12 January, 2020) #36987

Weekly Digest (5 January, 2020 - 12 January, 2020) #36987

Comments

weekly-digest bot commented Jan 12, 2020

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

OPEN PULL REQUEST

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES