Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent glass weight values #36858

Closed
Soup-de-Loop opened this issue Jan 10, 2020 · 1 comment · Fixed by #38689
Closed

Inconsistent glass weight values #36858

Soup-de-Loop opened this issue Jan 10, 2020 · 1 comment · Fixed by #38689
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@Soup-de-Loop
Copy link
Contributor

Describe the bug

Glass shards used in crafting glass are at odds in terms of weight with most of the things that can be crafted from them.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Make a player with and acquire the following: glass_shard, test_tube, flask_glass, jar_glass and bottle_glass, as well as the recipes for crafting them (glassblowing_book).
  2. Compare the weight values of each (volume is not as important due to shaping).
  3. Notice there's very little consistency, but glass shards are the worst offenders.

Expected behavior

Some degree of conservation of mass.

Screenshots

If applicable, add screenshots to help explain your problem.

glass shard
test tube
glass flask
glass jar
glass bottle

Versions and configuration

Current experimental, base DDA.

Additional context

Glass shards are intended to be able to be used as a weapon or cutting tool on the fly, regulating them to large pieces. While this is fine for many uses, having glassblowing available in the game that can craft items smaller than a shard breaks continuity and makes standardisation within recipes difficult while the smallest denomination remains more weight than several items crafted from it.

@Soup-de-Loop
Copy link
Contributor Author

My initial idea for an answer to this issue was simply to make a _small version of the shard that filled the role that smaller denominations of metals do as an ammo type with no inherent use, and allow that to be used to craft glass objects to fill the smaller items, and add it as a by-product when larger glass objects are used to craft smaller ones. I'm curious as to what others think, I did see previous issues that were more about the differences between shards and windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants