Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny or Unassuming characters with Muzzles of any kind have non-existent access to clothing for the 'Mouth' slot without excessive penalties #37553

Closed
Muffindrake opened this issue Jan 30, 2020 · 8 comments
Labels
stale Closed for lack of activity, but still valid.

Comments

@Muffindrake
Copy link
Contributor

Muffindrake commented Jan 30, 2020

Describe the bug

I had recently done another Tiny/Unassuming character and noticed that all of the Mouth gear that can actually be worn by a tiny muzzled character, which is limited to XL variants of mouth gear, cannot be downsized to fit small characters. This is an issue because the muzzle already locks you out of regular Mouth gear, but if you try to use the XL variant of a given gear piece, you suffer large penalties. The least encumbrance you can currently obtain is 20 assuming you wear the XL survivor divemask, refit it (which doesn't downsize it) and enable it.

As a side effect, enabling the divemask improves your vision (encumbrance goes from 40 to 20), because mouth and eye encumbrance are incorrectly tied to each other, but that's a matter for another bug report. That's not even a gas mask - the least-encumbrance option for gas masks is at a cool 40 encumbrance (i.e. XL survivor mask).

Steps To Reproduce

Steps to reproduce the behavior:

  1. Make character with Tiny/Unassuming and any type of Muzzle.
  2. Obtain any XL variant of a mask, preferably gas mask.
  3. Observe that said equipment can be refitted, if not already made to 'fit', and worn, but can't be downsized to reduce penalties.

Expected behavior

XL variants of masks should be downsizable. Logically, an XL variant of a mask is still XL in relation to the survivor who makes it. I'm not sure how to feel about goggles of all kinds being resizable.

Screenshots

image

Versions and configuration

  • OS: Gentoo Linux x86_64
  • Game Version: 0.D-11709-g9d46c1293e
  • Graphics Version: Terminal
  • Mods loaded: dda, Magiclysm, Garden Pots, Crazy Cataclysm, Bionic Slots
@Muffindrake
Copy link
Contributor Author

In extension, long versions of scarves are also not downsizable, which seems pretty silly.

@scorpion451
Copy link

I file this under the same heading as the inability to downsize any of the storage items when you already have reduced carrying capacity: basically turns the intended tradeoff penalty into a double-whammy, and in many cases it doesn't make sense that the item couldn't be resized, if just with regard to empty encumbrance.

@Muffindrake
Copy link
Contributor Author

Muffindrake commented Jan 30, 2020

As with the ammunition naming scheme I PR'd earlier, I suggest switching the naming scheme on these masks around as well. How about survivor mask, muzzled instead of XL next to the regular survivor mask? Then it'd make more sense to allow downsizing them, name-wise.

@Brian-Otten
Copy link
Contributor

We might not want to make it specifically for the muzzle, because there might be more mouth mutations that need adjusted masks, and having a separate mask for every mutated variant available would bloat the crafting menu too much.

Would be quite interesting if the recipes only showed up if you actually had the relevant mutations though, that would allow for a larger array of personally customized items without bloating the crafting menu.

@TechyBen
Copy link
Contributor

TechyBen commented Jan 31, 2020

Would generalising the resizing be better than making multiple size/shape clothing/masks?
Take away all the xl/mutant recipies for size/shape variation (with exception of unique "tail bow" / "8 tentacle shoes" / "stinger sock" mutant only items that have no "normal" like variants).

Then, any normal clothing that can be "refitted/sized/shaped" would have variations in the resize menu. It would have "adapt for tentacles/small/large/muzzle" and thus 4 or so options for them (or could just be 1 generic "mutant sized", but then I'd expect "tentacles" and XL to use more materials).

This way, the clothing need only have the tag "can be mutant" or "can be mini/mouse/tiny" or "can be tentacles" etc. With either a flat rate % material cost, or a small flag like:
X-ray proof Shirt;
[materials]rags (12), tin foil (400);
[refit tags]tentacles; rags (8), tin foil (100);

Perhaps descriptions of "you know how to refit this to fit mutations" if it's an item that can be refitted as a hint to players while in the crafting menu? :)

Basically, how we can stud with leather, but would be a "increase size" or "adjust for fitting" with additional options for mutations. Could even use different chars for mutation clothing. Like shirt++ for studding, shirt@ for large, and shirt% for tentacles? :p

@scorpion451
Copy link

scorpion451 commented Jan 31, 2020

That'd be a very cool way to do it, opening up the flexibility a lot more. I know quite a bit of the thinking on the blanket "mutation blocking" or "no resizing" thing is often some specific part of the item being conceptually difficult to imagine adjusting for. If armor instead had specific modifications blocked, that would at least mitigate the problem.

The XL variants, meanwhile, could instead be something like "adjustable (insert item)" or "custom (item)", with it accepting more or all of the mutation adjustments.

One of my longstanding and closely related "that just doesn't make sense" things I've wanted to see fixed is that my mouse can craft a given item from scratch, but can't make it in their own size. I can see the argument for not being able to adjust a scavenged suit of power armor to their size, but it's silly that they can't a build a custom backpack that's sized to fit them properly if they're making it from scratch.

Also: shirt~ for tentacles. X3

@stale
Copy link

stale bot commented Mar 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Mar 1, 2020
@stale
Copy link

stale bot commented Mar 31, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

4 participants