Weekly Digest (26 January, 2020 - 2 February, 2020) #37641

weekly-digest · 2020-02-02T11:03:51Z

Here's the Weekly Digest for CleverRaven/Cataclysm-DDA:

ISSUES

Last week 237 issues were created.
Of these, 151 issues have been closed and 86 issues are still open.

OPEN ISSUES

💚 #37632 Sensory Dulling CBM with Autodoc causes Addiction, by Orange01gaming
💚 #37623 Dependency install commands for vcpkg in doc do not work, by Hirmuolio
💚 #37620 fix totally broken guns pulled off of turrets yielding intact guns, by misterprimus
💚 #37619 Gun volume auditing for .380 ACP, by LaVeyanFiend
💚 #37618 uninstalling destroyed (XX) minigun from gunship yields an intact minigun, by misterprimus
💚 #37616 Sledge Expansion and Refactor, by Xanmyral
💚 #37615 WIP [ Aftershock ] Background Updates for Mutant NPCs, by Maleclypse
💚 #37614 Show decimals on ingame fragment mass., by Brian-Otten
💚 #37613 Lower on_dodge argument to 5 for boomer bile., by arijust
💚 #37612 Gun volume auditing for 5.7mm, by LaVeyanFiend
💚 #37606 Uninstalling gunmods takes no time, by snipercup
💚 #37605 Adjust grenade lethality test to count casualties differently from kills, by kevingranade
💚 #37604 [WIP] Add boiled fiddleheads and butter to relevant recipes, by ashGlaw
💚 #37603 Should electric zombies be dealing HP damage?, by Brian-Otten
💚 #37599 Tool belt rework, by RarkGrames
💚 #37598 Add the option to display ascii art in item description, by Fris0uman
💚 #37597 Improve directional highlight prompts, by ifreund
💚 #37592 Removed VARSIZE flag from accessories., by Kelenius
💚 #37591 player positional bug when re-entering a unloaded vehicle, by DaAngus
💚 #37588 Precision solderer CBM from Aftershock can't be used to craft CBMs, by eilaattwood
💚 #37586 Game freezes/crashes when activating CBM Ethanol Burner, by eirikwang
💚 #37585 Adjust grenade values, by Brian-Otten
💚 #37584 [CR] Make Aftershock atomic smartphone a valid music-playing device., by eilaattwood
💚 #37583 "Tried to add a duplicate entry" when eating., by Kelenius
💚 #37582 [WIP][CR] Adding vitamins and toxin levels monitor functions to Blood Analyser CBM, by eilaattwood
💚 #37579 the latest 0.D branch compile failed., by Chillbon
💚 #37578 Refluff power armour and adjust stats slightly, by I-am-Erk
💚 #37577 [WIP] Throwing knife bandolier, by ashGlaw
💚 #37576 Gun volume auditing for .38/.357 handguns, by LaVeyanFiend
💚 #37575 Allow black/whitelisting scenarios, by anothersimulacrum
💚 #37572 WIP: Migrate and update secret gas station from Fuji Structures, by I-am-Erk
💚 #37571 Overhaul civilian ammunition appearance rates., by kevingranade
💚 #37569 Atomic Coffee maker does not make coffee., by OptimisticNihlist
💚 #37554 Maps cause lag when there are many of them, by GGgatherer
💚 #37553 Tiny or Unassuming characters with Muzzles of any kind have non-existent access to clothing for the 'Mouth' slot without excessive penalties, by Muffindrake
💚 #37552 Use text snippets for tutorial messages, by ZhilkinSerg
💚 #37551 Canning water ratios are inconsistent among different sized cans, by jkraybill
💚 #37550 Fixed canning ratios for tomatoes / fruit / liver / red sauce, by jkraybill
💚 #37548 Don't add duplicate options to the page, by ZhilkinSerg
💚 #37540 Add subway maps, by wapcaplet
💚 #37535 Freshly fed sourdough starters are aging backwards, by DigitalLibrarian
💚 #37534 Display shown twice in graphics settings, by molkero
💚 #37533 Food rotting too early, by DigitalLibrarian
💚 #37532 Rational called shots (WIP, comments welome), by I-am-Erk
💚 #37530 [Aftershock] Mutant npcs to aftershock, by Maleclypse
💚 #37525 Cannot siphon from roof-mounted external tank (200l), by SSpook
💚 #37523 Change milking to an activity, restore udders on load catchup, by davidpwbrown
💚 #37512 Adds new starting scenario - Crazy party and new starting profession - Frat Boy/Sorority Girl, by CountAlex
💚 #37510 Give bomb fragments an armor piercing value, by Brian-Otten
💚 #37508 Health monitoring capabilities, by eilaattwood
💚 #37504 Canned fruit, canned tomatoes and canned livers not filling the right amounts, by Illgowiththisname
💚 #37501 Rework bladed/blunt polearms, by Brian-Otten
💚 #37497 WIP: Initial Blazemod re-work, by Soup-de-Loop
💚 #37496 Game difficulty when using guns, by Brian-Otten
💚 #37493 Classic Zombies / DDotD: Expand blacklists for classic mode, by I-am-Erk
💚 #37492 Make reach attacks not care about facing, by Brian-Otten
💚 #37476 Modding Bionics not possible with either copy-from or override flag, by GennFaol
💚 #37475 Move recipe book categorization from the recipe entry to the cookbook entry, by I-am-Erk
💚 #37471 Pie recipes should require butter., by I-am-Erk
💚 #37464 Streamline brewing times and recipes, by jkraybill
💚 #37460 Fix map memory edge case, by Trioct
💚 #37459 Allow a specified rotation when placing a nested map, by I-am-Erk
💚 #37456 Make the character less stoic to great pain, by Heaper327
💚 #37455 Shady basement spawns without house upstairs, by molkero
💚 #37454 WIP Transfer inhaler to NPC inventory on mission end, by wapcaplet
💚 #37453 Jsonize vehicle parts requiring other vehicle parts to be installed, by Hirmuolio
💚 #37452 Lab turrets don't shoot because of an ammo issue, by Alapaga
💚 #37450 Allow for specialization of activity parameters, by ifreund
💚 #37448 Game crashing, by tim77
💚 #37446 Clarify Health and make it work as expected, by I-am-Erk
💚 #37444 Added FM 20-32 Mine/Countermine Operations manual, by RarkGrames
💚 #37443 Vehicles Running/Idling After 20 Years/80 Seasons, by leefy-greens
💚 #37439 Chemical Imbalance Causes Permanent Very Cold Status, by Grubleafeater
💚 #37437 You can get a frozen uncontained item when crafting, by AMurkin
💚 #37431 Sus bathroom 3.5, by xanderrootslayer
💚 #37430 Docs: Explain the difference between tiles and curses, by jtagcat
💚 #37425 [WIP] Check loaded mapgen for being used at all., by BevapDin
💚 #37420 Aftershock atomic smartphone not playing music, by Entity-y
💚 #37416 Rebalance CBM drops rates, by Dziugaske
💚 #37415 Random NPC scared messages appear at any distance, by RydellV
💚 #37414 Move more string consts into cata_string_consts.h, by Ramza13
💚 #37404 Only give message about sleeping aid once, by Fris0uman
💚 #37403 Unable to view clothing modifications if only one option is available, by GGgatherer
💚 #37399 Allow ammunition to burn and make small explosions with loud sounds, by SeventhSandwich
💚 #37398 "Use this item" in NPC dialogue can lead to bugged armor removal, by GGgatherer
💚 #37397 "Experience to next level" shows useless value, by Melodeiro

CLOSED ISSUES

LIKED ISSUE

👍 #37497 WIP: Initial Blazemod re-work, by Soup-de-Loop
It received 👍 x13, 😄 x0, 🎉 x10 and ❤️ x2.

NOISY ISSUE

🔈 #37561 Added OA-93 pistol and carbine, by RarkGrames
It received 16 comments.

PULL REQUESTS

Last week, 216 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 74 pull requests were updated.
💛 #37619 Gun volume auditing for .380 ACP, by LaVeyanFiend
💛 #37616 Sledge Expansion and Refactor, by Xanmyral
💛 #37613 Lower on_dodge argument to 5 for boomer bile., by arijust
💛 #37612 Gun volume auditing for 5.7mm, by LaVeyanFiend
💛 #37605 Adjust grenade lethality test to count casualties differently from kills, by kevingranade
💛 #37604 [WIP] Add boiled fiddleheads and butter to relevant recipes, by ashGlaw
💛 #37598 Add the option to display ascii art in item description, by Fris0uman
💛 #37597 Improve directional highlight prompts, by ifreund
💛 #37592 Removed VARSIZE flag from accessories., by Kelenius
💛 #37585 Adjust grenade values, by Brian-Otten
💛 #37584 [CR] Make Aftershock atomic smartphone a valid music-playing device., by eilaattwood
💛 #37578 Refluff power armour and adjust stats slightly, by I-am-Erk
💛 #37577 [WIP] Throwing knife bandolier, by ashGlaw
💛 #37576 Gun volume auditing for .38/.357 handguns, by LaVeyanFiend
💛 #37575 Allow black/whitelisting scenarios, by anothersimulacrum
💛 #37572 WIP: Migrate and update secret gas station from Fuji Structures, by I-am-Erk
💛 #37552 Use text snippets for tutorial messages, by ZhilkinSerg
💛 #37550 Fixed canning ratios for tomatoes / fruit / liver / red sauce, by jkraybill
💛 #37540 Add subway maps, by wapcaplet
💛 #37530 [Aftershock] Mutant npcs to aftershock, by Maleclypse
💛 #37512 Adds new starting scenario - Crazy party and new starting profession - Frat Boy/Sorority Girl, by CountAlex
💛 #37497 WIP: Initial Blazemod re-work, by Soup-de-Loop
💛 #37493 Classic Zombies / DDotD: Expand blacklists for classic mode, by I-am-Erk
💛 #37460 Fix map memory edge case, by Trioct
💛 #37453 Jsonize vehicle parts requiring other vehicle parts to be installed, by Hirmuolio
💛 #37450 Allow for specialization of activity parameters, by ifreund
💛 #37444 Added FM 20-32 Mine/Countermine Operations manual, by RarkGrames
💛 #37431 Sus bathroom 3.5, by xanderrootslayer
💛 #37416 Rebalance CBM drops rates, by Dziugaske
💛 #37414 Move more string consts into cata_string_consts.h, by Ramza13
💛 #37404 Only give message about sleeping aid once, by Fris0uman
💛 #37399 Allow ammunition to burn and make small explosions with loud sounds, by SeventhSandwich
💛 #37330 NPC worker downtime - wandering and sitting on chairs, by davidpwbrown
💛 #37329 [WIP][CR] Add assign reader for damage instances, deprecate legacy damage code, by anothersimulacrum
💛 #37325 Allow NPCs to use basecamp storage zone for activities/jobs, by davidpwbrown
💛 #37314 Allow professions to start with a nearby vehicle - trucker profession, by davidpwbrown
💛 #37300 [WIP]NPC work log - for debugging and feedback, by davidpwbrown
💛 #37278 Add missing Krav Maga Weapons: Take 2, by JohnWildkins
💛 #37271 Moved mass grave terrain and special to map extra, by ZhilkinSerg
💛 #37263 WIP Autolearn recipes rework cooking part 1, by Maleclypse
💛 #37241 Rebalance archery take... 5?, by kevingranade
💛 #37220 Flintlock rilfe to musket name change and addition of a proper rifle, by Ker-Nes
💛 #37200 RC vehicle steering indicator & vision, by naka123
💛 #37158 Bugs are getting more gross, by I-am-Erk
💛 #37144 Chemistry Revolution: Lithium, by roaringjohn
💛 #37129 Remove scent diffusion over water by implementing NO_SCENT flag, by sayke
💛 #37103 Magical plants and where to find them, by John-Candlebury
💛 #36959 added batch time saving for all sugar recipes, by 8ctopus
💛 #36908 [Aftershock] Millyficent whately and the migo , by Maleclypse
💛 #36872 upgrade reversible recipe property, by 1n17
💛 #36870 Added "Trap Back button" option to Android prelaunch menu, by ZhilkinSerg
💛 #36816 Increased default overmap search radius, by Ker-Nes
💛 #36804 Add option to change position of look around windows, by Kilvoctu
💛 #36733 Add demon chitin armor & repairing dragon armor, by LaVeyanFiend
💛 #36722 Refactor monsters shift-v menu, by 8street
💛 #36703 Metal bridge over air tiles, by RafeHaab
💛 #36656 Item contents refactor (holster refactor 1 of 2), by KorGgenT
💛 #36645 Tweaked zombie soldier, cop and survivor drop lists, by Night-Pryanik
💛 #36578 WIP: A smaller surface research facility, by I-am-Erk
💛 #36233 Add fitness band and heartrate function for character, by CountAlex
💛 #36089 Reworked how crafting skill requirement display is generated., by ishtatann
💛 #35957 [WIP] Blazemod refactor, by ave-
💛 #35636 Magiclysm brown dragon, by ZhamelSeh
💛 #35522 [WIP]Aramid armor is like an onion, it has many layers: Kevlar rework, EOD gear and cut-gear., by tenmillimaster
💛 #35371 Add "looks_like" to all furniture and terrain, by XygenSS
💛 #34690 [WIP]Towing vehicles, by davidpwbrown
💛 #34667 Documentation for relic_data, by KorGgenT
💛 #34246 [WIP]NPC and player auto-crafting from workbench bills, by davidpwbrown
💛 #33829 Flyable Helicopters, by davidpwbrown
💛 #33776 Make vitamin deficiencies and hypervitaminosis non-cosmetic., by nexusmrsep
💛 #33556 CRIT Expansion Update [WIP], by Soupster89
💛 #33271 [CR] Removed penalties and base cost when calculating obtain_cost() for wielded item, by Raschert0
💛 #32017 [WIP][CR] Provide point types with coordinate system type-safety, by jbytheway
💛 #32012 [WIP] Fix 3d shadowcasting, by ifreund

MERGED PULL REQUEST

COMMITS

Last week there were 221 commits.
🛠️ Merge pull request #37630 from wapcaplet/mission-doc-cleanup Clean up doc formatting by ZhilkinSerg
🛠️ Clean up doc formatting The "goal" section was all running together in github's markdown viewer; changing this to table formatting makes it consistent with other tables in this doc. Also replaced tabs with spaces in JSON example and trimmed trailing whitespace. by wapcaplet
🛠️ Merge pull request #37626 from ymber/obsolete_locations Obsolete location mods by ZhilkinSerg
🛠️ Merge pull request #37628 from Qrox/fix-recipe-check Fix faction camp blueprint recipe autocalculation consistency by ZhilkinSerg
🛠️ Merge pull request #37627 from Fris0uman/doc Add missing bionic doc by ZhilkinSerg
🛠️ Merge pull request #37629 from RarkGrames/Glock-17-magazine-spawn-fix Glock 17 default magazine bugfix by ZhilkinSerg
🛠️ Vehicle_parts.json sorting (#37595) by RarkGrames
🛠️ [Monsters.json sorting (#37625) * Monsters.json sorting

Update fish.json
Moved searchlight to turrets.json](689d7b5) by RarkGrames
🛠️ [Ranged.json sorting (Ranged.json sorting #37622) * Ranged.json sorting
Sorted out archery.json and crossbows.json](bb182bf) by RarkGrames
🛠️ [Monstergroups.json sorting pt. 2 (Monstergroups.json sorting pt. 2 #37621) * Renamed monstergroups_egg.json to eggs.json
Sorted out the rest of monstergoups.json](a224e4a) by RarkGrames
🛠️ Update 9mm.json by RarkGrames
🛠️ Update blueprint requirements by Qrox
🛠️ Fix incorrect OR quality requirements to AND quality requirements by Qrox
🛠️ Consistent consolidation by Qrox
🛠️ Sort requirement data before comparison by Qrox
🛠️ Add missing bionic doc by Fris0uman
🛠️ Obsolete location mods by ymber
🛠️ Merge pull request #37617 from anothersimulacrum/sap-temp Set sap temperature when producing it by Rivet-the-Zombie
🛠️ Set sap temperature when producing it by anothersimulacrum
🛠️ Merge pull request #37528 from wapcaplet/no-headphone-safecracking Prevent safecracking attempt while wearing earbuds by ZhilkinSerg
🛠️ Merge pull request #37600 from anothersimulacrum/wield-ui Fix bug in wield UI by ZhilkinSerg
🛠️ Monstergroups.json sorting (#37596) by RarkGrames
🛠️ Merge pull request #37593 from RarkGrames/Melee.json-sorting Melee.json sorting by ZhilkinSerg
🛠️ Merge pull request #37607 from snipercup/docinstrument-description DOC: renamed an instrument description field from "descriptions" to "player_descriptions" by ZhilkinSerg
🛠️ Merge pull request #37608 from ifreund/say-no-to-vending-groups Remove vending item groups from nonsensical places by ZhilkinSerg
🛠️ Tool name strings to objects (#37609) by snipercup
🛠️ Fix default chance for ammo effects to 100 (#37602) by ZhilkinSerg
🛠️ Merge pull request #37601 from BevapDin/hou Deduplicate some JSON data: by kevingranade
🛠️ Remove vending item groups from nonsensical places by ifreund
🛠️ renamed an instrument description field from "descriptions" to "player_descriptions" by snipercup
🛠️ Merge pull request #37594 from Night-Pryanik/allow-diving-and-surfacing Moved diving code before the check for terrain's "climbality" by ZhilkinSerg
🛠️ Merge pull request #37587 from BrettDong/i18n Routine i18n updates on 31 Jan 2020 by ZhilkinSerg
🛠️ Remove item definition of "tool_black_powder_bomb" as it has a migration defined. There is no item of that id anymore. Existing items will be converted to "can_bomb" as defined in the migration entry. by BevapDin
🛠️ Deduplicate some JSON data: Some objects in the JSON files are defined multiple times (that is: there are several object with the same "type" and "id" member). Most of those duplicates are identical. Some are slightly different. The game will usually overwrite the previously loaded data with new the date from the new definition, so when the duplicates are different, this uses the value from the later definition. ---- How do we even get those duplicates? Could it be because the location of those definitions is not easily predictable ("grave" is defined in "terrain-manufactured.json" and in "terrain-floors_outdoor.json")? But some of those duplciate appear right next to each other (e.g. in "overmap_terrain_recreational.json"). by BevapDin
🛠️ Properly display proportional damage for guns Prevent the truncation of proportional damage values by using floats for the display functions. The numbers here are small enough that the precision of floats should never be a problem. by anothersimulacrum
🛠️ Fix astyle regression by ZhilkinSerg
🛠️ Moved diving code before the check for "climbality" by Night-Pryanik
🛠️ Melee.json sorting by RarkGrames
🛠️ Routine i18n updates on 31 Jan 2020 by BrettDong
🛠️ [Fix a few wrong coordinate conversions that cause generation of meaningless overmaps (Fix a few wrong coordinate conversions that cause generation of meaningless overmaps #37581) * Duck-tape ms_to_omt_copy
Duck-tape another ms_to_omt_copy
Fix typo in comments](1eb07c7) by park66665
🛠️ Fix construction menu filtering and a few other tweaks (#37549) by Qrox
🛠️ Merge pull request #37566 from CleverRaven/fix-lit-candle-firestarter Add firestarter action to lit candle by Rivet-the-Zombie
🛠️ Merge pull request #37436 from Qrox/construction-id Migrate construction to use int_id and string_id by ZhilkinSerg
🛠️ Merge pull request #37560 from Fris0uman/readspell Spell books show up in the [R]ead menu by ZhilkinSerg
🛠️ Merge pull request #37570 from snipercup/Comestible-modern-json-3 Comestible-modern-json-3 by ZhilkinSerg
🛠️ [Return the default font to Terminus and slightly improve fallback handling (Return the default font to Terminus and slightly improve fallback handling #37573) * Always load unifont as a fallback

This prevents users from shooting themselves in the foot by selecting a
different font and removing unifont from their font list

Add better default font settings

Return the default font to Terminus

Show wait popup after data files are loaded and before the save is loaded
Remove unused member of loading_ui
Do not move cursor to start](61cd828) by Qrox
🛠️ #37537 make lit candle a firestarter by jkraybill
🛠️ Merge pull request #37545 from ralreegorganon/fix-bionic-basement-region-references Remove all references to basement_bionic from region settings by ZhilkinSerg
🛠️ Remove all references to basement_bionic from region settings by ralreegorganon
🛠️ Merge pull request #37509 from Brian-Otten/mixed-smokeless-gunpowder rename mixed gunpowder by ZhilkinSerg
🛠️ More repairs like flags by Brian-Otten
🛠️ Replace axe-kick with spinning back kick and add roundhouse kicks/feints to TKD (#37362) by sayke
🛠️ Merge pull request #37467 from SeventhSandwich/fix-bikerack-vehicle-tracking Fixes overmap vehicle tracking/remembering with bike rack by ZhilkinSerg
🛠️ Merge pull request #37541 from Night-Pryanik/cbm-slots-ui-fix Fixed offset for bionics slots UI by ZhilkinSerg
🛠️ Merge pull request #37538 from Qrox/preserve-filter Fix consuming menu filter cleared after consuming an item by ZhilkinSerg
🛠️ Merge pull request #37531 from curstwist/add-reins-and-tackle-to-item_groups let reins_tackle spawn by ZhilkinSerg
🛠️ Fixed offset for bionics slots UI by Night-Pryanik
🛠️ Adjust MRE contents to better reflect real MREs (#37484) by Dziugaske
🛠️ [Make bicycles more likely to exist (Make bicycles more likely to exist #37457) * Make bicycles more likely to exist

Prior to this change, bicycles had only a 3% chance among the vehicle
pool (less than half that of armored vehicles) on city streets.
This seemed way too low, so I wanted to give bikes a fairer chance.

Fixes #37451

This commit changes three vehicle groups, including:

city_vehicles:

Bicycle equally likely as the standard car,
or twice as likely as a Hippie Van.
Dirt bike as likely as a Hatchback or Hippie Van
Electric bicycle as likely as a Beetle or RV

suburban_home:

Bicycle as likely as standard car
Dirt bike as likely as SUV
Electric bicycle possible, as likely as scooter or sports car

parkinglot:

Bicycle as likely as car or flatbed truck
Dirt bike possible, as likely as hatchback or motorcycle

Reduce bicycle spawn frequency somewhat

Based on PR feedback from other devs/players, I'm dialing back the
bicycle spawn frequency significantly from my previous commit.

The total adjustment now is that bicycles are roughly 1.5 - 2 times as
likely to appear in city streets, suburban homes, and parking lots, as
they are in the current experimental branch.

Adjustments made in this commit include:

In "city_vehicles" (i.e. in streets everywhere):

"bicycle" weight is 800 (originally 400), making them
rarer than "car", "car_hatch", "ambulance", or "hippie_van",
but more likely than "beetle", "car_mini", "bus", "rv", or "4x4_car".
Same chance of spawning as a "pickup" or "suv".
"bicycle_dirt" weight is 200 (originally 0, impossible), making them
as likely as "suv_electric", "motorcycle", "truck_swat", or "fire_engine"
"bicycle_electric" weight is back to 100 (originally 100)

In "suburban_home":

"bicycle" weight is now 200 (originally 150),
same chance as "4x4_car" or "motorcycle"
"bicycle_dirt" weight is now 150 (originally 125),
same chance as "car_anmlcmpt"

And in "parkinglot":

"bicycle" weight left at 1000 (originally 500)
"bicycle_dirt" removed again (back how it was before)

Partially fixes #37451

Add a bike shed to house08 and house_patio

To get a few more pedal-powered bicycles and parts into the world in a
less conspicuous way than simply spamming them onto the city streets

Fixes #37451

As suggested by @I-am-Erk, this adds a 6x6 nestable mapgen module
containing a simple metal bike shed. It's modeled after the 6x6_junk
shed, with flimsier metal walls, but still having locked (pickable)
metal doors, so it's not a total smash-and-grab.

Inside the shed is a 50% chance of finding a "bikeshop" vehicle, most
often a "bicycle", "bicycle_dirt", or "bicycle_electric", but with some
chance of "tandem", "scooter", "unicycle" etc.

It's furnished with a workbench and metal shelf, across which there is a
low (10%) chance of seeing 1-3 "bikeshop_tools", usually a bike part
(wheel, horn, foot crank, saddle) but sometimes such goodies as a wrench,
screwdriver set, duct tape, or even (very low chance) a toolbox!

I found two houses where this shed seems to fit well with the layout
("house08" and "house_patio"), and included the new bike shed with the
same probability as "shed_6x6_woodworker".

Have correctly linted JSON

My JSON failed linting, now it should work

Remove the trailing newline

To see if that is enough lint removal](7a6ccdd) by wapcaplet
🛠️ Keep consuming menu filter when consuming multiple items by Qrox
🛠️ [fix magic basement spawn, update interior (#37486) * fix magic basement spawn, update

add save support
shift dog spawns to a new house

since I'm using this for the magic basement, moving the dog spawns for player survivability.](3045555) by curstwist
🛠️ Use mod_moves; mp3 on/off time to 2 seconds By making the mp3 player take 2 seconds to turn off, the avatar status indicator is correctly updated, and earphone effect is correctly refreshed, allowing a safecrack attempt immediately after turning off the mp3 player. Increasing the mp3 turn-on time to 2 seconds for symmetry. by wapcaplet
🛠️ let reins_tackle spawn by curstwist
🛠️ Merge pull request #37527 from ZhilkinSerg/fix-bionic-basement-savegame-migration Fix savegame migration of bionic basement overmap terrain by codemime
🛠️ Merge pull request #37470 from Qrox/recipe-loading-perf Improve recipe loading speed by changing auto requirements calculation to requirements check in unit test by ZhilkinSerg
🛠️ Merge pull request #37524 from ymber/survivor_helmets Obsolete survivor helmets by ZhilkinSerg
🛠️ [Cyberjunkie fix (#37529) * Update professions.json

Fixed AA](bbc4cf2) by RarkGrames
🛠️ Add migration for bionic basement by ZhilkinSerg
🛠️ Make toggling mp3 player on/off take 1 second With the logic to prevent safecracking with effect_earphones, there was an edge case immediately after activating them mp3 player, still allowing a safecrack attempt to be made. Fixes #36013 Turning an mp3 player on or off now takes 1 second, where before it took 0 time. This allows effect_earphones to become active before the next action, preventing a safecracking attempt. Unfortunately, it leaves a second edge case when the mp3 player turns off (which also takes only 1 second); there, for some reason I can't determine, the effect_earphones status remains alive for a further second. As a side note, this 1-turn delay on activation, and 2-turn delay on deactivation has been clearly visible in-game in the experimental branch for quite some time, using the DeadPeople tileset. You may have noticed after turning on an mp3 player that it takes 1 further second for the icon to appear above your avatar, and that after turning it off, 2 seconds must elapse before the icon disappears. Now, because of the 1-second (de-)activation time, turning it on gives the icon right away, but turning it off still takes 1 more second. by wapcaplet
🛠️ Obsolete survivor helmets by ymber
🛠️ Update Integrated toolset Drilling quality to match description (#37521) by RobertoVGoulart
🛠️ Adjust Hub 01 environmental suit values (#37519) by Dziugaske
🛠️ [Obsolete flaming weapons (Obsolete flaming weapons #37406) * Obsolete flaming weapons
Add flaming weapons to crazy cataclysm](4230ca3) by ymber
🛠️ [Improve overmapbuffer searching routines (Improve overmapbuffer searching routines #37482) * Add simple unit tests for closest_points functions
Minor simplification and optimization of closest_points functions
Allow specifying minimal distance in closest_points functions
Use closest_points functions for overmap buffer search](36402aa) by codemime
🛠️ Merge pull request #37513 from Kelenius/BookReadTimeFix Lowered excessive reading times of some cooking books. by ZhilkinSerg
🛠️ Merge pull request #37517 from Qrox/fix-opt-menu-crash Fix crash when exiting from options menu after failed loading by ZhilkinSerg
🛠️ Merge pull request #37514 from AMurkin/fix-mod-gg-plural-names Fix plural names in the Generic Guns mod by ZhilkinSerg
🛠️ Merge pull request #37518 from AMurkin/fix-rust-arithmetical-error Fix arithmetical error on load by ZhilkinSerg
🛠️ Avoid % 0 by AMurkin
🛠️ Fix crash when exiting from options menu after failed loading by Qrox
🛠️ Prevent safecracking if wearing earphones To increase realism and game consistency regarding partial deafness Partially fixes #36013 Disallows an attempt at safecracking while player has effect_earphones. Due to a loophole caused by mp3 player activation being instantaneous, it is still possible to begin safecracking immediately after putting on the mp3 player (but not after 1 turn has passed with the mp3 active). by wapcaplet
🛠️ Fix incorrect key. Use the new name format by AMurkin
🛠️ Lowered excessive reading times of some cooking books. by Kelenius
🛠️ Merge pull request #37511 from RarkGrames/Speech.json-fix Speech copy-paste fixes by ZhilkinSerg
🛠️ Update speech.json by RarkGrames
🛠️ rename mixed gunpowder mixed gunpowder is made from smokeless gunpowder and not having smokeless in the description is confusing. by Brian-Otten
🛠️ Change maintainer of DinoMod to @damien (#37490) by damien
🛠️ Clean skill rust code (#37281) by Fris0uman
🛠️ Changed maintainer for Mythical Martial Arts mod (#37483) by Hymore246
🛠️ Doc office fix (#37507) by RarkGrames
🛠️ Merge pull request #37498 from Brian-Otten/Ballistic-vest-lookss-like-MBR Adds looks_like flags by ZhilkinSerg
🛠️ Grenades.json into explosives.json (#37506) by RarkGrames
🛠️ Merge pull request #37505 from RarkGrames/Armor.json-sorting-pt.-7 Armor.json sorting pt. 7 by ZhilkinSerg
🛠️ Refactor 3 catacurses functions a bit (#37500) by AMurkin
🛠️ Merge pull request #37499 from Night-Pryanik/let-go-of-grabbing-fix Fix breaking grab without spending moves by trying to climb up or down by ZhilkinSerg
🛠️ Merge pull request #37503 from Qrox/font-fallback Adds font fallback support for map and overmap fonts by ZhilkinSerg
🛠️ Armor.json sorting pt. 7 by RarkGrames
🛠️ Merge branch 'master' of https://github.com/cleverraven/Cataclysm-DDA by RarkGrames
🛠️ Adds font fallback support for map and overmap by Qrox
🛠️ Move check for ability to climb to the very beginning by Night-Pryanik
🛠️ Merge pull request #37487 from wapcaplet/pet-carrier-messages Show messages when pet is captured or released by ZhilkinSerg
🛠️ Merge pull request #37491 from LilShiningMan/lsm---minor-book.json-revamp Update books.json by ZhilkinSerg
🛠️ Adds looks_like flags by Brian-Otten
🛠️ Reorganize monsters.json and audit CLASSIC tag (#37480) by I-am-Erk
🛠️ Merge pull request #37485 from KorGgenT/orichalcum-frame-fix fix orichalcum frames in tests by ZhilkinSerg
🛠️ Merge pull request #37479 from curstwist/fix-high-tech/low-life-start fix high tech low life start by Rivet-the-Zombie
🛠️ Update books.json cleaned up a couple spawn lists. by LilShiningMan
🛠️ Show messages when pet is captured or released When using a pet carrier to capture or release a pet, it was not displaying any kind of success message in the log. Now you will get i.e. "You capture the cat in your pet carrier." "You release the cat." Following the example of similar log messages in these functions, I added one message for successful capture, and one for successful release. This commit was going to be a simple two-line addition, but I discovered that release_monster was deleting the name of the contained animal as part of releaseing it, thus I got an empty string when trying to log it. The solution, setting a local contained_name variable to remember the animal name, had a nice side-effect of making several other lines a little cleaner and more readable after slight refactoring, so I am including that too. by wapcaplet
🛠️ Change blueprint auto-calculation to blueprint requirements check in unit test by Qrox
🛠️ Mainline INT based learning changes (#37465) by ZhilkinSerg
🛠️ move cupboard to furniture-surfaces, give workbench properties (#37481) by esotericist
🛠️ fix orichalcum frames in tests by KorGgenT
🛠️ Update regional_map_settings.json by curstwist
🛠️ Merge branch 'master' of https://github.com/cleverraven/Cataclysm-DDA by RarkGrames
🛠️ fix high tech low life start by curstwist
🛠️ Merge pull request #37423 from anothersimulacrum/sleep Sleep deprivation cleanup by ZhilkinSerg
🛠️ Merge pull request #37478 from curstwist/fix-house-starting-locations- fix house starting locations by ZhilkinSerg
🛠️ fruit wine requires yeast (#37463) by jkraybill
🛠️ Merge pull request #37387 from Qrox/explicit-int-id Make int_id::operator int explicit by ZhilkinSerg
🛠️ Merge pull request #37419 from Inglonias/mod-documentation Updated and improved MODDING.md by ZhilkinSerg
🛠️ Change "Disassemble everything" wording (#37440) by RobertoVGoulart
🛠️ [Display Correct read times at character creation (Display Correct read times at character creation #37472) * Display Correct read times at character creation
move read_speed() to character](b8000b3) by Fris0uman
🛠️ Merge pull request #37473 from ralreegorganon/fix-house-matching Fix house id matching in hardcoded missions by ZhilkinSerg
🛠️ Make feature template use headers, not bold text (#37474) by I-am-Erk
🛠️ I volunteer as tribute: Claiming a maintainer role on Classic Zombies. (#37477) by I-am-Erk
🛠️ [Armor.json sorting pt. 6 (Armor.json sorting pt. 6 #37468) * Undergarment.json and tool_armor.json
Revert "Undergarment.json and tool_armor.json"

This reverts commit 873c253.

Tool_armor.json
Undergarment.json
Armor.json + things missed from earlier
Moved barrette to jewelry
Hot pants, loincloth, leggings to legs_clothes.json
Update tool_armor.json](2be9d70) by RarkGrames
🛠️ fix house starting locations by curstwist
🛠️ Fix house id matching in hardcoded missions by ralreegorganon
🛠️ [Tool name plural and name to object (Tool name plural and name to object #37466) * Tool name_plural and name to object
Names to object, volume to string
Names to object
Update data/json/items/tool/lighting.json
Update data/json/items/tool/cooking.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/items/tool/electronics.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/items/tool/explosives.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/items/tool/lighting.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Update data/json/items/tool/lighting.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Co-authored-by: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com](3da5eb4) by snipercup
🛠️ Update tool.json (#37367) by gavin1337
🛠️ [Turret mount crafting recipe (#37321) * Update recipe_vehicle.json

Update recipe_vehicle.json
Update recipe_vehicle.json
Update recipe_vehicle.json
Update recipe_vehicle.json
Update recipe_vehicle.json
Update recipes.json](f79a581) by Dziugaske
🛠️ insecticide can be made with lye powder, or much less lye #36396 (#37462) by jkraybill
🛠️ added period to warrener dialogue line. (#37461) by jkraybill
🛠️ Revert "Undergarment.json and tool_armor.json" This reverts commit 873c25376d535be690538787151043802c6986fa. by RarkGrames
🛠️ Undergarment.json and tool_armor.json by RarkGrames
🛠️ fixed bikerack vehicle tracking fixed bikerack wiping overmap tracking for carried vehicles by SeventhSandwich
🛠️ Added hint about minefields to the Overrun scenario (#37442) by RarkGrames
🛠️ Gun modern json name format (#37447) by snipercup
🛠️ Merge pull request #37458 from CleverRaven/John-Candlebury-microlab-1 Fix typo in microlab_generic_edge.json by Rivet-the-Zombie
🛠️ [Obsolete mods (Obsolete mods #37272) * Obsolete mods
Merge no_reviving_zombies into classic_zombies](4d28f3e) by ymber
🛠️ Update microlab_generic_edge.json by John-Candlebury
🛠️ Ignore skill requirements with debug hammerspace by Qrox
🛠️ Correctly hide unavailable constructions by Qrox
🛠️ Migrate constructions to use int_id and string_id by Qrox
🛠️ Add missing [ ] to fix game load (#37449) by Hirmuolio
🛠️ [Build roofs over dirt, and dig stairs in roofed dirt tiles (Build roofs over dirt, and dig stairs in roofed dirt tiles #37427) * Build roofs over dirt, and dig stairs in roofed dirt tiles
Fixed some things that got broken somehow
Linted files and added DIGGABLE to outdoor dirt floors
Linting

Co-authored-by: ColdandDead 59815584+ColdandDead@users.noreply.github.com](6c29cba) by ashGlaw
🛠️ [Make edamame and soybeans smokable (#37335) * Make edamame and soybeans smokable

Soybeans and edamame can both be smoked. Edamame spoils quickly and when roasted lasts 2 seasons. Soybeans last a year in-game the smoking process makes them edible but lasting only 2 seasons. Internet searches confirm smoked edamame and soy nut recipes.](00ce335) by CSHague
🛠️ Fix footsteps translation (#37402) by 8street
🛠️ [Armor.json sorting pt. 5 (#37441) * Storage.json and sheath.json

Update armor.json
Added torso_clothes.json](4eee8c7) by RarkGrames
🛠️ [Item category modern json name (Item category modern json name #37435) * Item category modern json name
Names to objects](98a689e) by snipercup
🛠️ Split sausage_wasteland recipe into two recipes. (#37316) by arijust
🛠️ Merge pull request #37295 from KorGgenT/orichalcum-frame [magiclysm] create orichalcum frame vehicle part by ZhilkinSerg
🛠️ Merge pull request #37438 from Kilvoctu/go-crack-house Update Graphical Overmap by ZhilkinSerg
🛠️ update with crack houses by Kilvoctu
🛠️ [Mutation modern names format (Mutation modern names format #37434) * Mutations modern names
Name string to object
Names to objects
Name to object
Names to objects
Names to objects
Names to objects
Name to object
Debug mutations names to objects
Names to objects
Names to objects
Names to objects
Names to objects
Names to objects
Facial hair names to objects
Facial hair names to objects](6a39a45) by snipercup
🛠️ update ITEM_CATEGORY documentation - property priority_zones (#37407) by snipercup
🛠️ [Move item desription into basic_info (Move item description to the top of the item info panel #37422) It makes sense to show the basic description of what an item is
before showing the category, volume, weight, material, owner,
ammunition, charges, magazine, and disassembly information.

This commit moves item descriptions to the top of basic_info, just below
the item name, to make it easier to see what I'm looking at.](8fcf7b8) by wapcaplet
🛠️ [item group sorting 6 (#37408) * item group sorting 6

created two new .jsons -- jewellery_gems and activities_hobbies. Moved various lists from item_groups into other .jsons.](c4b028f) by LilShiningMan
🛠️ Mutations modern json names and doubles (#37426) by snipercup
🛠️ Merge pull request #37421 from snipercup/Update-documentation-on-gun-valid-mod-locations Update documentation on gun valid mod locations by ZhilkinSerg
🛠️ Merge pull request #37432 from jkraybill/jk3 pluralization and grammar fixes: spam, canned salmon, charcoal, quest by ZhilkinSerg
🛠️ Merge pull request #37428 from curstwist/fix-house_crack-spawns fix house spawns by Rivet-the-Zombie
🛠️ pluralization and grammar fixes: spam, canned salmon, charcoal, Brigitte LaCroix quest by jkraybill
🛠️ fix house spawns by curstwist
🛠️ Remove useless melatonin tablet iuse, external opt There wasn't really any reason for the melatonin tablet to have a separate iuse, instead of using the consume drug actor. The external option for sleep deprivation was also not very useful, and was removed as such. While converting the melatonin tablet to the consume drug iuse, I noticed it could not use time_duration strings, so I enabled the use of those for it. Making these changes trigerred test failures, so I made adjustments to the tests to fix those. by anothersimulacrum
🛠️ Update documentation on gun valid mod locations by snipercup
🛠️ Updated and improved MODDING.md by Inglonias
🛠️ Merge pull request #37413 from Fris0uman/panhunger Replace Food and Drink labels with Hunger and Thirst by ZhilkinSerg
🛠️ Merge pull request #37410 from RarkGrames/Armor.json-sorting-pt.-4 Armor.json sorting pt. 4 by ZhilkinSerg
🛠️ Merge pull request #37417 from jbytheway/uninitialized-resistances Avoid uninitialized resistance values by ZhilkinSerg
🛠️ Merge pull request #37418 from CountAlex/spacefix Adds extra whitespace to fix tests fail by ZhilkinSerg
🛠️ Adds extra whitespace to fix tests fail by CountAlex
🛠️ Avoid uninitialized resistance values The resistances constructor for monsters left the DT_ELECTRIC value uninitialized. This led to inconsistent behaviour and CI test failures. Ensure it's initialized. by jbytheway
🛠️ Merge pull request #37412 from Inglonias/fix-mags-again Fix magazine unloading (again) by ZhilkinSerg
🛠️ Update bunker.json (#37411) by RarkGrames
🛠️ Replace Food and Drink labels with Hunger and Thirst by Fris0uman
🛠️ Fix magazine unloading (again) by Inglonias
🛠️ security van uses orichalcum by KorGgenT
🛠️ Armor.json sorting pt. 4 by RarkGrames
🛠️ [Add suffixes and base recipes to Modular Turrets-based mods to allow proper uncrafting + other tweaks Fixes #37291 (#37373) * Modernize craft times

Craft times were still in 100 moves per 6 seconds era.

Add id_suffix "from_scrap" to manhack recipes, remove inactive manhack from scrap recipe, modern time

Adding Id suffix should enable one to craft manhacks from the whole components or rebuild them from scrap components and damaged manhacks. This should allow inactive manhacks to be dismantled again fixing CleverRaven:#37291

Removed inactive manhack from "from_scrap" entries.

Added from scratch recipes and changed suffix ids

Changed suffix ids to "repair" on repair recipes to manage ambiguity.

Added base recipes that match the recipes for CROWS II turret sans weapon with additional programming and mechanical expertise and difficulty being the separation between the manufacture types, implying the user has to train or program the AI core to operate the weapon. Repair recipes require electrohack to repair, the majority of the time spent hacking the broken AI core into its original function. The from-scratch recipes added imply the builder is working from a reset AI core that is is in working order and will easily accept programming instructions and the additional 10 minutes added is for completely building the turret from parts.](16ef318) by CSHague
🛠️ Refactor and update Graphical Overmap mod (#37305) by Kilvoctu
🛠️ Aftershock Bloodhound Drones (#37131) by Maleclypse
🛠️ Merge pull request #37395 from SeventhSandwich/chemlab-hotplate-rework Removed redundant hotplate on onboard chemistry lab by ZhilkinSerg
🛠️ Revoked RECHARGE flag from Aftershock's UPS items/tools (#37331) by gwyter
🛠️ [Pull out more string consts into cata_string_consts.h (#37394) * Pull out string consts from tons of files

Rollback large files
Rollback
Rollback
Rollback
FIx test/typo
Astyle](9e48800) by Ramza13
🛠️ Merge pull request #37400 from LilShiningMan/lsm---item-group-sort-5 Item Group Sorting #5 by ZhilkinSerg
🛠️ Merge pull request #37401 from Night-Pryanik/query-fix Refresh whole screen after selecting "What to do with your X" query by ZhilkinSerg
🛠️ Merge pull request #37307 from RarkGrames/Underbrush-nocollide Added coverage to underbrush by Rivet-the-Zombie
🛠️ Refresh whole screen after selecting "What to do with your X" by Night-Pryanik
🛠️ Item Group Sorting #5 created 3 new .jsons -- locations_mapextras, agriculture and gear_civilian. Moved spawn lists from item_groups and gear.jsons into various lists. by LilShiningMan
🛠️ [Standardize JSON times to strings (Json time standardization for some constructions, vehicle parts and ammo #37396) Integer times in construction.json were converted directly to minutes
(confirmed in-game that these are the correct construction times).

Integer times in some ammo and vehicle recipes were converted such that
100 is 1 turn, and since 1 turn is 1 second, this means "time: 4000" is
a duration of 40 seconds, and "time: 30000" is a duration of 5 minutes.
Again I checked in-game for these recipes to be sure of my
interpretation (despite a few of these seeming unrealistically quick,
such as the 5-second boat oars).

Partial fix for #36110](88cbf39) by wapcaplet
🛠️ [Obsoleted Special 700 (#37385) * Added Special 700 to guns_rifle_improvised

Reverted the item group addition
Replaced the gun with a Reminton 700 in mapgen files
Obsoleted the gun](8c1d65e) by RarkGrames
🛠️ [Increased recycle center mundane loot tenfold (Increased recycle center mundane loot tenfold #37388) * Buffed mundane item weights
Increased loot amount tenfold
Increased recycle bin storage capacity
Update data/json/itemgroups/locations.json

Co-Authored-By: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com

Added some more items and fixed wrong ones

Co-authored-by: I-am-Erk 45136638+I-am-Erk@users.noreply.github.com](94515f5) by RarkGrames
🛠️ Update inventory.cpp removed redundant hotplate pseudoitem by SeventhSandwich
🛠️ Mainline sleep deprivation (#37317) by anothersimulacrum

CONTRIBUTORS

Last week there were 48 contributors.
👤 ZhilkinSerg
👤 wapcaplet
👤 RarkGrames
👤 Qrox
👤 Fris0uman
👤 ymber
👤 Rivet-the-Zombie
👤 anothersimulacrum
👤 snipercup
👤 kevingranade
👤 ifreund
👤 BevapDin
👤 Night-Pryanik
👤 BrettDong
👤 park66665
👤 Kilvoctu
👤 Kromgart
👤 AMurkin
👤 Maleclypse
👤 Muffindrake
👤 CountAlex
👤 jkraybill
👤 ralreegorganon
👤 Brian-Otten
👤 sayke
👤 Dziugaske
👤 curstwist
👤 codemime
👤 RobertoVGoulart
👤 Kelenius
👤 damien
👤 Hymore246
👤 I-am-Erk
👤 LilShiningMan
👤 esotericist
👤 KorGgenT
👤 gavin1337
👤 SeventhSandwich
👤 John-Candlebury
👤 Hirmuolio
👤 ashGlaw
👤 CSHague
👤 8street
👤 arijust
👤 Inglonias
👤 jbytheway
👤 gwyter
👤 Ramza13

STARGAZERS

Last week there were 29 stagazers.
⭐ Coder12a
⭐ lwyj123
⭐ qwaszx000
⭐ Qwertyfizz
⭐ mipesom
⭐ inphobia
⭐ krapans
⭐ dragonlotion
⭐ Xdynix
⭐ RQWorldblender
⭐ tetraphoz
⭐ GeekDuanLian
⭐ chengjingfeng
⭐ VanillaBrooks
⭐ maybeinit
⭐ MKoesters
⭐ helloqinglan
⭐ Ende93
⭐ wangyichengsh
⭐ Moop204
⭐ jackbondpreston
⭐ justinyanme
⭐ zhangbbsday
⭐ Yany1
⭐ ywjno
⭐ JoaoCostaIFG
⭐ SpeedHacked
⭐ Aristarhys
⭐ NieelsHub
You all are the stars! 🌟

RELEASES

That's all for last week, please 👀 Watch and ⭐ Star the repository CleverRaven/Cataclysm-DDA to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

weekly-digest bot added the weekly-digest label Feb 2, 2020

ZhilkinSerg closed this as completed Feb 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (26 January, 2020 - 2 February, 2020) #37641

Weekly Digest (26 January, 2020 - 2 February, 2020) #37641

weekly-digest bot commented Feb 2, 2020

Weekly Digest (26 January, 2020 - 2 February, 2020) #37641

Weekly Digest (26 January, 2020 - 2 February, 2020) #37641

Comments

weekly-digest bot commented Feb 2, 2020

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES