player positional bug when re-entering a unloaded vehicle

[DaAngus]

Describe the bug

If the player loads a bike while on the seat, leaves the seat, unloads the bike and moves on the seat
debugmsg( "map::board_vehicle: passenger (%s) is already there",

A clear and concise description of what the bug is.

Steps To Reproduce

Drive you bike to the bike rack. Stop driving. Load the Vehicle. leave the vehicle and unload it. reenter the vehicle.

Expected behavior

There should not be any passenger on a loaded vehicle. Its just some pipes and strings.
If we get pulled over we are done

Clear all tags for passengers or prevent loading a vehicle while inside the loaded vehicle.
If its to general with "while inside a vehicle" a player cant load while, for example, in the doorframe of the main vehicle.

Versions and configuration

• OS: Linux
  • OS Version: Arch
• Game Version: 0.D-11791-g2c159093e7-dirty [64-bit]
• Graphics Version: Tiles
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food]
  ]

Additional context

Add any other context about the problem here.

DEBUG : map::board_vehicle: passenger (Jimmy 'Gentle' Nash) is already there

FUNCTION : void map::board_vehicle(const tripoint &, player *)
FILE : src/map.cpp
LINE : 958

something something vehicle.cpp line 2368?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[kevingranade]

I agree with preventing loading whilecstanding on the vehicle to be loaded.

[kevingranade]

It looks like the place to address this is in vehicle_use.cpp:1738, vehicle::use_bike_rack()

The logic to do so escapes me at the moment though.

[irwiss]

This is done in 4b86beb