Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

western holster has too little storage volume #48532

Closed
Aeiouuu01234 opened this issue Apr 15, 2021 · 1 comment · Fixed by #49883
Closed

western holster has too little storage volume #48532

Aeiouuu01234 opened this issue Apr 15, 2021 · 1 comment · Fixed by #49883
Labels
<Bug> This needs to be fixed Good First Issue This is a good first issue for a new contributor Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON

Comments

@Aeiouuu01234
Copy link
Contributor

Describe the bug

in comparison with a normal holster, the western holster has less than half of storage volume and cannot be used to holster most of the handguns in the game

Steps To Reproduce

check teh stats

Expected behavior

mabey update the stats based on the standard holster

Screenshots

west holster

Do not take a screenshot of the crashing window. Please provide the crash logs in the "Additional context" -->

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 0.E-10383-gad91f6a [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

@actual-nh actual-nh added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Items: Containers Things that hold other things labels Apr 15, 2021
@Antrocon
Copy link

can confirm. 400ml max volume doesn't make sense for western holster
in-game volume & lenght for s&w model 10: 402ml / 252mm.
in-game volume & lenght for s&w 619: 608ml / 278mm
in-game volume & lenght for colt SAA: 324ml / 208mm

RL lenght for s&w 10 (4" barrel): 237mm
RL lenght for s&w 619 (4" barrel): 240mm
RL length for colt SAA (4" 3/4 barrel; shortest): 260mm

from western holster description i can assume it represents cowboy-style holster one might see in western movies and expect revolvers like colt SAA to fit in perfectly.
from RL dimension values i can assume colt SAA, s&w 10, s&w 619 are roughly same size, so we should expect those to fit into same "western holster", along with majority of regular-sized revolvers we have in game.
the in-game dimension values for those revolvers do look off, but i'm not sure if it worth to audit&correct dimensions of all revolvers and won't change OP issue: colt SAA in-game (supposed to fit into WH) is way less volume than in RL or other revolvers have way too much volume than in RL.
given that, it seems bumping up western holster max volume to something more reasonable would be appropriate.

refs:
https://en.wikipedia.org/wiki/Smith_%26_Wesson_Model_619_%26_620
https://weaponsystems.net/system/626-Smith+%26+Wesson+Model+10+Military+%26+Police
https://en.wikipedia.org/wiki/Colt_Single_Action_Army
https://www.kirkpatrickleather.com/product/idaho-john-rig-model-idj-2/

@actual-nh actual-nh added <Bug> This needs to be fixed [JSON] Changes (can be) made in JSON and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Apr 20, 2021
@anothersimulacrum anothersimulacrum added the Good First Issue This is a good first issue for a new contributor label Jun 5, 2021
I-am-Erk pushed a commit that referenced this issue Jul 12, 2021
…evolvers (#48532) (#49883)

* Incresed volume of western holster main pocket to 850ml (#48532)

* Increased volume and length of pocket in western holster (#48532)

* Tweked volume slightly to fit Lemat revolver
ZhilkinSerg added a commit that referenced this issue Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Good First Issue This is a good first issue for a new contributor Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants