Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underground drug deal spawns aboveground terrain #50696

Closed
eltank opened this issue Aug 12, 2021 · 4 comments · Fixed by #50697
Closed

Underground drug deal spawns aboveground terrain #50696

eltank opened this issue Aug 12, 2021 · 4 comments · Fixed by #50697
Labels
<Bug> This needs to be fixed Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display

Comments

@eltank
Copy link
Contributor

eltank commented Aug 12, 2021 •
edited
Loading

Describe the bug

The "drug deal" map extra, when spawned underground at z=-4, overwrites the tunnel terrain with z=0 terrain (grass).

Steps To Reproduce

Explore z=-4 tunnels until the drug deal map extra is triggered. May work with other map extras and other z<0 levels.

Expected behavior

Drug deal critters and loot spawning on top of subway tracks, without overwriting the terrain.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 6b656d5a [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food]
    ]

Additional context

Save Lakeview.zip
@eltank eltank mentioned this issue Aug 12, 2021
Merged
@eltank
Copy link
Contributor Author

eltank commented Aug 12, 2021

Spawning the map extra from the debug menu also works to reproduce the bug, no need to rely on chance.

@eltank
Copy link
Contributor Author

eltank commented Aug 12, 2021

Other common map extras such as military, scientists and college kids don't have this problem.

@eltank
Copy link
Contributor Author

eltank commented Aug 12, 2021

This bug was probably introduced by #48327

@eltank
Copy link
Contributor Author

eltank commented Aug 12, 2021

Found a simple fix, will make a PR soon.

@eltank eltank mentioned this issue Aug 12, 2021
Merged
@actual-nh actual-nh added <Bug> This needs to be fixed [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix drug deal map special terrain eltank/Cataclysm-DDA
2 participants
@eltank @actual-nh