Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drug deal map special terrain #50697

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

eltank
Copy link
Contributor

@eltank eltank commented Aug 12, 2021

Summary

Bugfixes "Fix drug deal map special terrain"

Purpose of change

Fixes #50696
When the drug deal map special was jsonified (#48327) it was accidentally changed to replace the terrain with dirt and grass. This doesn't make sense underground, nor on any overground OMT other than "field" (e.g. roads).

Describe the solution

Change the special's terrain map to "t_null" so that it doesn't actually change any terrain.

Describe alternatives you've considered

Testing

Force spawn the map special underground, check that corpses and enemies spawn but terrain stays the same.

Additional context

Special spawned after the fix:
image

@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Map / Mapgen Overmap, Mapgen, Map extras, Map display [JSON] Changes (can be) made in JSON labels Aug 12, 2021
@kevingranade kevingranade merged commit 8dcc284 into CleverRaven:master Aug 12, 2021
@eltank eltank deleted the fix_drug_deal branch August 12, 2021 06:51
satheon49 pushed a commit to satheon49/Cataclysm-DDA that referenced this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underground drug deal spawns aboveground terrain
3 participants