Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customisable @-menu #51156

Closed
ghost opened this issue Aug 28, 2021 · 20 comments
Closed

Customisable @-menu #51156

ghost opened this issue Aug 28, 2021 · 20 comments
Labels
Info / User Interface Game - player communication, menus, etc. stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@ghost
Copy link

ghost commented Aug 28, 2021

Is your feature request related to a problem? Please describe.

Currently there is no way to switch off or edit UI elements on the character screen like you can do with the sidebar. I think an option to customise @-menu would benefit players who play on smaller screens or don't like the default look of the menu.

Describe the solution you'd like

Add an option to customise @-menu.

Describe alternatives you've considered

None

@Night-Pryanik Night-Pryanik added <Suggestion / Discussion> Talk it out before implementing Info / User Interface Game - player communication, menus, etc. labels Aug 28, 2021
@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

Kind of related, about visible scrollbars: #50928

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

In @: Currently, there are 9 windows in 3 columns, 8 of them are in one column, one spans across all three columns.

Having 3 columns is different from the sidebar because there is only 1 column.

Do you, or anyone, have any mockups? How would you solve this 3-column dilemma? Or better: what UI would you want, if you could get anything?

I'm thinking... Pick the number of columns, if you make a window across more columns, pick the shortest column above and shrink the others to its size. So we would be able to get what we have now.

I will add pictures from the last experimental shortly... Well... When it finally compiles...

@ghost
Copy link
Author

ghost commented Aug 28, 2021

Maybe all 3 colums should have separate edit buttons?

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

I'm thinking more like you can select the number of columns and their width...

[Satisfaction sound] Uuuhhhh... that's nice! I could finally make it wide enough for proficiencies!

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

Latest experimental with arbitrary size:

image

Note: SKILLS tab don't have a scrollbar unless selected, I will look into that... Also, they are the only ones to have a scrollbar on the left.

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

What's your resolution @mourningsun? If I am to look at it, I would like your eyes, not theoretical ones...

@ghost
Copy link
Author

ghost commented Aug 28, 2021

What's your resolution @mourningsun? If I am to look at it, I would like your eyes, not theoretical ones...

I play on a tablet and I dont have a PC. My terminal size in game would be equivalent to 1045x576

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

What would happen if you remove one of the windows somewhere in the middle. Would they leave empty space or group together with the remaining windows?

Yes, that has to be addressed.
I think, when you make a multi-column window, it has to have windows in all columns above itself, or none (has to be first).
You still could get weird behaviour, but the player can see that and it would not crash, hopefully. They would just change it around.

Weird behaviour: You stack 5 windows in the first column, and two short windows in the 2nd and 3rd column, one each. Add a 3 wide multi-column window under all that. Then the first column is smushed like hell, but the player sees that and decides that that's not what they want and changes that around.

So when you have a multi-column window, all windows above it get as much space, as the shortest column needs.
Then we just divide the space fairly, as I have done in #50892 for EFFECTS + PROFICIENCIES, only for N windows instead of just 2.

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

I think, for now, If I could get a working version without multi-column and then add it after, it would be amazing still, right? Yeah, we will see. That's a nice project!

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

I see, currently, the width of @ menu is decided like that, because it is the minimum width the game supports...

@ghost
Copy link
Author

ghost commented Aug 28, 2021

I think, for now, If I could get a working version without multi-column and then add it after, it would be amazing still, right? Yeah, we will see. That's a nice project!

Cant wait to try it out!

@ghost
Copy link
Author

ghost commented Aug 28, 2021

Latest experimental with arbitrary size:

image

Note: SKILLS tab don't have a scrollbar unless selected, I will look into that... Also, they are the only ones to have a scrollbar on the left.

The window in the middle with the descriptions takes a lot of place, can it be smaller or maybe moved to the bottom of the screen?

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

I hope you will be able to do make it a regular window and scroll it if necessary? By page up/down, or some other secondary scrolling mechanics

@ghost
Copy link
Author

ghost commented Aug 28, 2021

Would there be separate editing screen or mode where you can rearrange and edit columns and their contents? I guess that would be the hardest part to implement.

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

Would there be separate editing screen or mode where you can rearrange and edit columns and their contents? I guess that would be the hardest part to implement.

Yes, that's exactly what I would like to implement! Like it is with the sidebar, I thought you asked for that :D

@ghost
Copy link
Author

ghost commented Aug 28, 2021

Would there be separate editing screen or mode where you can rearrange and edit columns and their contents? I guess that would be the hardest part to implement.

Yes, that's exactly what I would like to implement! Like it is with the sidebar, I thought you asked for that :D

Of course!

Also here's how my character screen looks in my current game. I can post fonts and font settings later if necessary.

If there were an editing option I would stack Stats, Encumbrance and Speed on top of each other in the first column on the left and remove age, height, weight and blood type from Stats window. Skills and Traits would take second column and Effects and Proficiencies in third with hidden Bionics window. The whole top part with a name would be hidden and description window I would put at the bottom under all three columns or maybe also hide it.

Screenshot_2021-08-28-22-18-50

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

Ok, there is what I would like to implement in the first PR from what you said:

If there were an editing option I would:

  • stack Stats, Encumbrance and Speed on top of each other in the first column on the left
  • and remove age, height, weight and blood type from Stats window.
  • Skills and Traits would take second column
  • and Effects and Proficiencies in third with hidden Bionics window.
  • The whole top part with a name would be hidden
  • and description window I would put at the bottom under all three columns or maybe also hide it.

and remove age, height, weight and blood type from Stats window.

That's something for future improvement.

The whole top part with a name would be hidden

Actually, Tere is not only name, but also [y]Switch Gender [?], this would probably fall under "Hint", like in the sidebar menu

and description window I would put at the bottom under all three columns or maybe also hide it.

There is actually quite a lot going on, but that's the beauty of customization, your taste doesn't have to match with mine and we're both happy 😄

@Brambor
Copy link
Contributor

Brambor commented Aug 28, 2021

I would add: The ability to remove titles (EFFECTS, TRAITS, BIONICS, SKILLS...), because experienced player doesn't need them.

@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Apr 28, 2022
@Night-Pryanik
Copy link
Contributor

Closing as stale, since stalebot can't do this by itself.

@Night-Pryanik Night-Pryanik closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants